Skip to content
This repository has been archived by the owner on Oct 23, 2020. It is now read-only.

Ocean Core Review Process

Jump to bottom
Doug Jacobsen edited this page May 3, 2013 · 2 revisions

This document describes the review process used by the MPAS-Ocean developers team.

Updating Develop Branch

First Time Setup

  1. Add MPAS-Dev/MPAS as a remote to your local repo: git remote add [email protected]:MPAS-Dev/MPAS.git
  2. Create a develop branch: git branch --no-track develop master

After Setup is Completed

  1. Update information about MPAS-Dev/MPAS: git fetch MPAS-Dev/MPAS
  2. Switch to your local develop branch: git checkout develop
  3. Update local develop branch to MPAS-Dev/MPAS's develop branch: git merge MPAS-Dev/MPAS/develop

Review

  1. Build an up-to-date develop branch executable
  2. Build a normal feature branch executable
  3. Build a debug feature branch executable

Run each of the three executables on the same test case. Results should be bit-for-bit identical between all three. Results should also be bit-for-bit restartable between all three.

After all three runs pass both of these bit-for-bit tests, the feature can be locally merged. The locally merged feature can then be tested again with the develop branch executable. Assuming it again passes the tests, this merged copy can be pushed back onto MPAS-Dev/MPAS/develop.

Clone this wiki locally