MPAS Ocean Review Guide

Reviewing MPAS-Ocean Pull Request

---

When reviewing a pull request to be merged into ocean/develop or ocean/private, please make sure the following are true:

1. No hard coded real values occur without the _RKIND specifier. i.e. 5.0 -> 5.0_RKIND.
2. All mpas_pool_get_array and mpas_pool_get_field calls from a pool with multiple time levels have the time level argument. i.e. call mpas_pool_get_array(statePool, 'layerThickness', layerThickness) -> call mpas_pool_get_array(statePool, 'layerThickness', layerThickess, timeLevel).
3. The changes before and after the merge build with all of our supported compilers.
4. None of the commits in the history of the branch touch files outside of src/core_ocean (i.e. git diff --name-status HEAD MPAS-Dev/MPAS/ocean/develop only lists files in src/core_ocean).
   1. If a commit does touch files outside, the commit need to be removed. The change cannot be removed in a separate commit.
5. All of the other cores still build.
6. Features of the ocean are still passing (i.e. bit-reproducibility across decompositions, and bit-restartability)