Documenting manual QA flows V2 #21962
Labels
area-documentation
Issues relating to documentation, in the codebase and off.
epic
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
team-extension-platform
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
chloeYue
added
the
area-documentation
This was referenced Feb 19, 2024
seaona
added a commit
that referenced
this issue
Feb 20, 2024
## **Description** In this PR we add the scenario for the flow: sign typed v4 with hardware wallet. This task belongs to the effort of documenting manual QA flows[ in this Epic](#21962). ## **Related issues** Fixes: #22029 ## **Manual testing steps** 1. Check steps are coherent with the flow in the video Note: You can see the table rendered [here](https://github.com/MetaMask/metamask-extension/blob/test-scenario-sign4-hw/test/scenarios/13.%20sign/sign%20typed%20data%20v4%20with%20hardware%20wallet.csv) for an easier review ## **Screenshots/Recordings** Performing the steps defined in the scenario https://github.com/MetaMask/metamask-extension/assets/54408225/766be1d0-77dd-4d5c-8f4d-d2b2f3d384fb ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
seaona
added a commit
that referenced
this issue
Feb 21, 2024
## **Description** In this PR we add the scenario for the flow: sign typed v3 with hardware wallet. Note: sign typed data v3 only work with QR-based wallets, not with Trezor nor Ledger. This task belongs to the effort of documenting manual QA flows[ in this Epic](#21962). ## **Related issues** Fixes: #22028 ## **Manual testing steps** Check steps are coherent with the flow in the video (at the end of the video the signature is closed due to a current identified [issue](#23074)) Note: You can see the table rendered [here](https://github.com/MetaMask/metamask-extension/blob/1c387482f46acd9c1fd16b26f44acea9817152d6/test/scenarios/13.%20sign/sign%20typed%20data%20v3%20with%20hardware%20wallet.csv) for an easier review ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/54408225/322eda2a-5e5d-411b-bd17-29dd46cb137b ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
13 tasks
sleepytanya
added a commit
that referenced
this issue
Mar 1, 2024
## **Description** In this PR we add the scenario for the flow 'Set custom spending cap for custom token'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). ## **Related issues** Fixes: #22411 ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/66de2251a266cd1b5d97901a826624dbb378ad03/test/scenarios/4.%20tokens/approve%20custom%20erc20%20amount.csv). ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/104780023/3fc47750-fc3f-4346-a81b-10427dda1dd3 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: seaona <[email protected]> Co-authored-by: seaona <[email protected]>
This was referenced Mar 5, 2024
This was referenced Mar 10, 2024
segun
added a commit
that referenced
this issue
Mar 14, 2024
## **Description** In this PR we add the scenario for the flow: eth sign with hardware wallet. This task belongs to the effort of documenting manual QA flows[ in this Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23314?quickstart=1) ## **Related issues** Fixes: #22027 ## **Manual testing steps** 1. Check the video below. ## **Screenshots/Recordings** Performing the steps defined in the scenario https://github.com/MetaMask/metamask-extension/assets/44811/ed18a2d7-7862-481f-aa7c-bb3d011fc440 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
davidmurdoch
pushed a commit
that referenced
this issue
Mar 14, 2024
## **Description** In this PR we add the scenario for the flow: eth sign with hardware wallet. This task belongs to the effort of documenting manual QA flows[ in this Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23314?quickstart=1) ## **Related issues** Fixes: #22027 ## **Manual testing steps** 1. Check the video below. ## **Screenshots/Recordings** Performing the steps defined in the scenario https://github.com/MetaMask/metamask-extension/assets/44811/ed18a2d7-7862-481f-aa7c-bb3d011fc440 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
13 tasks
segun
added a commit
that referenced
this issue
Mar 18, 2024
## **Description** In this PR we add the scenario for the flow: eth sign with hardware wallet. This task belongs to the effort of documenting manual QA flows[ in this Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23313?quickstart=1) ## **Related issues** Fixes: #22026 ## **Manual testing steps** 1. Check the video below. ## **Screenshots/Recordings** Performing the steps defined in the scenario https://github.com/MetaMask/metamask-extension/assets/44811/a858aa5e-2bde-411c-bc4e-dd787efa778f ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
13 tasks
sleepytanya
added a commit
that referenced
this issue
Mar 19, 2024
## **Description** In this PR we add the scenario for the flow 'Check custom nonce toggle'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23418?quickstart=1) ## **Related issues** Fixes: [21989](#21989) ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/3db07ce715f306ba329c0c4cf987b97893109e51/test/scenarios/17.%20settings/advanced/check%20custom%20nonce%20toggle.csv). ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/104780023/6fb61cbe-485b-4cf8-a301-1841b70fcb91 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sleepytanya
added a commit
that referenced
this issue
Mar 19, 2024
…#23569) ## **Description** In this PR we add the scenario for the flow 'Navigate through multiple unapproved transactions, approve and reject individually, reject all at once'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23569?quickstart=1) ## **Related issues** Fixes: [22410](#22410) ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. 2. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/2d6b8f9df35a33d9382ba5e7f6e7cd00fefebf1d/test/scenarios/3.%20transactions/navigate%20multiple%20transactions.csv). ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/104780023/9163cde9-8c94-4dde-9a48-b1ba9baca337 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sleepytanya
added a commit
that referenced
this issue
Mar 19, 2024
## **Description** In this PR we add the scenario for the flow 'Deploy contract, deposit and withdraw'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23536?quickstart=1) ## **Related issues** Fixes: [22018](#22018) ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. 2. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/03029e205061995b64c42f236da743dd92c9ddf0/test/scenarios/3.%20transactions/deposit%20and%20withdraw.csv). ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/104780023/149dc5fb-e071-46dd-a1f8-c9ebdca9038e ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sleepytanya
added a commit
that referenced
this issue
Mar 19, 2024
## **Description** In this PR we add the scenario for the flow 'Deploy failing contract'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23408?quickstart=1) ## **Related issues** Video: https://github.com/MetaMask/metamask-extension/assets/104780023/e430875d-0849-448f-873f-bc47815e3972 Fixes: [22017](#22017) ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/01bb0d2f1e38ef4833a44fac7284d7168c9d43bb/test/scenarios/3.%20transactions/deploy%20failing%20transaction.csv). ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
This was referenced Mar 20, 2024
segun
added a commit
that referenced
this issue
Mar 20, 2024
## **Description** In this PR we add the scenario for the flow: eth sign with hardware wallet. This task belongs to the effort of documenting manual QA flowshttps://github.com//issues/21962. [](https://codespaces.new/MetaMask/metamask-extension/pull/23606?quickstart=1) ## **Related issues** Fixes: [#22025](#22025) ## **Manual testing steps** 1. Check video below ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/44811/ce0891f1-a70d-46f6-b097-2850fae99f02 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
segun
added a commit
that referenced
this issue
Mar 20, 2024
## **Description** In this PR we add the scenario for the flow: eth sign with hardware wallet. This task belongs to the effort of documenting manual QA flowshttps://github.com//issues/21962. [](https://codespaces.new/MetaMask/metamask-extension/pull/23609?quickstart=1) ## **Related issues** Fixes: [#22024](#22024) ## **Manual testing steps** 1. Check the video below. ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/44811/70d4c2c1-b871-45f6-bd6c-ddefe76f4c34 ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
13 tasks
segun
added a commit
that referenced
this issue
Mar 21, 2024
## **Description** In this PR we add the scenario for the flow: eth sign with hardware wallet. This task belongs to the effort of documenting manual QA flowshttps://github.com/#21962. [](https://codespaces.new/MetaMask/metamask-extension/pull/23623?quickstart=1) ## **Related issues** Fixes: [#22023](#22023) ## **Manual testing steps** 1. Check the video below ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/44811/1c182d29-8dd0-4ac1-80a9-f2879606c1ca ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
sleepytanya
added a commit
that referenced
this issue
Apr 19, 2024
…ion with the same nonce' (#23872) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** In this PR we add the scenario for the flow 'Cancel transaction by sending subsequent transaction with the same nonce'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). User flow summary: - create 'Send' transaction nonce with very low gas fees - send the next transaction with the 0 value and previous nonce to yourself to cancel the first transaction - validate that the first transaction is cancelled [](https://codespaces.new/MetaMask/metamask-extension/pull/23872?quickstart=1) ## **Related issues** Fixes: [23830](#23830) ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. 2. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/57c1f2861fc70a00da97d1c778fd66ddf774e7ae/test/scenarios/3.%20transactions/cancel%20transaction%20using%20same%20nonce.csv). ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> https://github.com/MetaMask/metamask-extension/assets/104780023/efc7e4bf-d946-4735-bd90-d21556d487b3 ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sleepytanya
added a commit
that referenced
this issue
Apr 20, 2024
## **Description** In this PR we add the scenario for the flow 'Send transactions with custom nonce'. This task belongs to the effort of documenting manual QA flows in this [Epic](#21962). [](https://codespaces.new/MetaMask/metamask-extension/pull/23714?quickstart=1) User flow summary: - validate that 'Customize transaction nonce' settings enable should get the appropriate text field for entering nonce. - validate that the nonce should be incremented by one. - validated that the nonce is reduced and transaction fails due to low nonce value. ## **Related issues** Fixes: [23570](#23570) ## **Manual testing steps** 1. Verify that the test steps align with the sequence in the video. 2. You can find rendered table [here](https://github.com/MetaMask/metamask-extension/blob/710741dff8ba9698b76b637b383c2237d03f2983/test/scenarios/3.%20transactions/send%20transactions%20with%20custom%20nonce.csv). ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-extension/assets/104780023/e4573f5d-3d51-4c78-8623-cdaf9554879d Popup notification about failed low nonce transaction: <img width="380" alt="Screenshot 2024-03-19 at 7 12 56 PM" src="https://github.com/MetaMask/metamask-extension/assets/104780023/a675c163-ead2-4ea6-9bb7-4a1f4f98ce7c"> ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/23314?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23313?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23418?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23569?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23536?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23408?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23606?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23609?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23623?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23872?quickstart=1){kind=link}
](https://codespaces.new/MetaMask/metamask-extension/pull/23714?quickstart=1){kind=link}
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
Following the epic #18727
Here are the rest userflows to document
Goal: produce high level QA instructions
Scenarios should be documented here: https://github.com/MetaMask/metamask-extension/tree/develop/test/manual-scenarios
Scenarios in this list should be distributed to the corresponding teams to document them.
#22022
#22019
#22016
#22015
#22014
#22013
#22012
#22011
#22010
#22009
#22008
#22005
#22004
#22003
#22002
#22001
#22000
#21999
#21998
#21997
#21996
#21995
#21994
#21993
#21992
#21991
#21990
#21987
#21984
#21983
#21982
#21981
#21980
#21979
#21978
#21977
#21976
#21975
#21974
#21973
#21972
#21969
#21968
#21967
#21966
#21964
#22021
Hardware wallet:
#22032
#22031
#22030
The text was updated successfully, but these errors were encountered: