-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add scenario sign typed v4 with hardware wallet #23043
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
@@ -4,7 +4,7 @@ Step,Test steps,Preconditions,Test data,Expected result,Notes | |||
3,"Keep Ethereum Mainnet as the selected network. Click on account menu icon. Click ""Add account or hardware wallet"".",,,"The ""Add account"" modal is shown.", | |||
4,"On ""Add account"" modal, click ""Add hardware wallet"" button.",,,"""Connect a hardware wallet"" screen is shown. User can choose between different options to connect a hardware: Ledger, Trezor, Lattice, or QR-based. ""Continue"" button is disabled.", | |||
5,Choose an option to connect hardware wallet.,We need to have a hardware wallet setted up to test this functionality.,"e.g. choose ""Ledger""","""Continue"" button is enabled.", | |||
6,"Plug the hardware wallet directly into computer, then unlock it.",,password for hardware wallet,"Hardware wallet is detected by MetaMask. ""Select an account"" screen is shown on MetaMask, accounts on hardware wallet are shown on this screen.","If you use Ledger, you need to open the Ethereum app on Ledger. If you use Trazor, make sure you use the correct passphrase." | |||
6,"Plug the hardware wallet directly into computer, then unlock it.",,password for hardware wallet,"Hardware wallet is detected by MetaMask. ""Select an account"" screen is shown on MetaMask, accounts on hardware wallet are shown on this screen.","If you use Ledger, you need to open the Ethereum app on Ledger. If you use Trezor, make sure you use the correct passphrase." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23043 +/- ##
========================================
Coverage 68.53% 68.53%
========================================
Files 1089 1089
Lines 42972 42972
Branches 11440 11440
========================================
Hits 29448 29448
Misses 13524 13524 ☔ View full report in Codecov by Sentry. |
Builds ready [9db775f]
Page Load Metrics (961 ± 56 ms)
Bundle size diffs
|
Description
In this PR we add the scenario for the flow: sign typed v4 with hardware wallet.
This task belongs to the effort of documenting manual QA flows in this Epic.
Related issues
Fixes: #22029
Manual testing steps
Note: You can see the table rendered here for an easier review
Screenshots/Recordings
Performing the steps defined in the scenario
sign-v4-hw.mp4
Pre-merge author checklist
Pre-merge reviewer checklist