-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add scenario sign typed v4 with hardware wallet #23043
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
093dbd0
Add scenario sign typed v4 with hardware wallet
seaona da8ccc6
Fix format for multiple results
seaona 701af3d
More format fixing
seaona ea331dd
more formatting
seaona 0fee99d
Add quotes to Sign typed data
seaona 59368ae
Add preconditions column.
seaona 9db775f
fix ortography
seaona File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
test/scenarios/13. sign/sign typed data v4 with hardware wallet.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| Steps,Test Steps,Preconditions,Test Data,Expected Result,Notes | ||
| 1,Open the extension.,,,The Welcome Back screen is shown., | ||
| 2,Proceed to Unlock the wallet.,,password (8 characters min).,"The Ether balance is shown on the overview. | ||
| The wallet address is shown on the overview.", | ||
| 3,"Click on account menu icon. Click ""Add account or hardware wallet"".",,,"The ""Add account"" modal is shown.", | ||
| 4,"On ""Add account"" modal, click ""Add hardware wallet"" button.",,,"""Connect a hardware wallet"" screen is shown. User can choose between different options to connect a hardware: Ledger, Trezor, Lattice, or QR-based. ""Continue"" button is disabled.", | ||
| 5,Choose an option to connect hardware wallet.,We need to have a hardware wallet set up to test this functionality.,"e.g. choose ""Ledger""","""Continue"" button is enabled.", | ||
| 6,"Plug the hardware wallet directly into computer, then unlock it.",,Password for hardware wallet,"Hardware wallet is detected by MetaMask. ""Select an account"" screen is shown on MetaMask, accounts on hardware wallet are shown on this screen.","If you use Ledger, you need to open the Ethereum app on Ledger. If you use Trezor, make sure you use the correct passphrase." | ||
| 7,"Choose one or multiples accounts that user wants to connect. Then click ""Unlock"".",,,, | ||
| 8,Click account menu icon to open accounts list.,,,"In accounts list, all selected hardware wallet accounts are shown, and they are all flagged with harware wallet name to be distinguished from other accounts.", | ||
| 9,Select one hardware wallet account.,,,"The Ether balance for the selected hardware wallet account is shown on the overview. | ||
| The selected account address is shown on the overview.", | ||
| 10,Open the test dapp in another tab.,,https://metamask.github.io/test-dapp/,, | ||
| 11,Click Connect.,,,"The MetaMask popup is opened with the Connect with MetaMask screen displayed. | ||
| Your imported hardware wallet account is selected.", | ||
| 12,Click Next and Connect with the hardware wallet account.,,,"The MetaMask popup is closed. | ||
| You are connected to the test dapp.", | ||
| 13,"Click ""Sign Typed Data V4"".",,,"The info modal instructions for signing with hardware wallet is displayed. | ||
| The signature message is in JSON formatting.", | ||
| 14,Accept the Signature in the hardware wallet device.,,,The signature hash is displayed on the test dapp., | ||
| 15,Verify signed hash.,,,The signed address is correctly verified.,The address shown in the test dapp is the same as the hardware wallet account. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo fix