Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario 'Cancel transaction by sending subsequent transaction with the same nonce' #23872

Merged
merged 6 commits into from
Apr 19, 2024

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Apr 5, 2024

Description

In this PR we add the scenario for the flow 'Cancel transaction by sending subsequent transaction with the same nonce'.
This task belongs to the effort of documenting manual QA flows in this Epic.

User flow summary:

  • create 'Send' transaction nonce with very low gas fees
  • send the next transaction with the 0 value and previous nonce to yourself to cancel the first transaction
  • validate that the first transaction is cancelled

Open in GitHub Codespaces

Related issues

Fixes: 23830

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
  2. You can find rendered table here.

Screenshots/Recordings

1.mov

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya added area-documentation Issues relating to documentation, in the codebase and off. team-confirmations-system DEPRECATED: please use "team-confirmations" label instead release-11.15.0 Issue or pull request that will be included in release 11.15.0 labels Apr 5, 2024
@sleepytanya sleepytanya self-assigned this Apr 5, 2024
@sleepytanya sleepytanya requested a review from a team as a code owner April 5, 2024 22:35
Copy link
Contributor

github-actions bot commented Apr 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [e3f812c]
Page Load Metrics (480 ± 384 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint613561116130
domContentLoaded108226178
load502269480800384
domInteractive108226178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.05%. Comparing base (7cd2d10) to head (e3f812c).

❗ Current head e3f812c differs from pull request most recent head 791e3da. Consider uploading reports for the commit 791e3da to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23872      +/-   ##
===========================================
+ Coverage    67.48%   69.05%   +1.57%     
===========================================
  Files         1244     1164      -80     
  Lines        48783    44489    -4294     
  Branches     12729    11888     -841     
===========================================
- Hits         32921    30721    -2200     
+ Misses       15862    13768    -2094     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sleepytanya sleepytanya requested a review from seaona April 6, 2024 00:12
@hjetpoluru hjetpoluru self-requested a review April 7, 2024 02:19
Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@metamaskbot
Copy link
Collaborator

Builds ready [ba13cf1]
Page Load Metrics (1604 ± 666 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint733781518440
domContentLoaded115424105
load57331916041386666
domInteractive115424105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya merged commit 45d8425 into develop Apr 19, 2024
68 of 69 checks passed
@sleepytanya sleepytanya deleted the cancel-transaction-using-same-nonce branch April 19, 2024 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@metamaskbot metamaskbot added release-11.16.0 Issue or pull request that will be included in release 11.16.0 and removed release-11.16.0 Issue or pull request that will be included in release 11.16.0 labels Apr 19, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-11.15.0) on PR and removing other release labels (release-11.16.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. release-11.15.0 Issue or pull request that will be included in release 11.15.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

User flow - cancel transaction using custom nonce feature.
4 participants