Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario deploy failing contract #23408

Merged
merged 7 commits into from
Mar 19, 2024

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Mar 10, 2024

Description

In this PR we add the scenario for the flow 'Deploy failing contract'.
This task belongs to the effort of documenting manual QA flows in this Epic.

Open in GitHub Codespaces

Related issues

Video:

456.mov

Fixes: 22017

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
    You can find rendered table here.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya requested a review from a team as a code owner March 10, 2024 06:58
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya marked this pull request as draft March 10, 2024 06:59
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (ffd58dd) to head (b2d3308).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23408   +/-   ##
========================================
  Coverage    68.45%   68.45%           
========================================
  Files         1141     1141           
  Lines        43769    43769           
  Branches     11729    11729           
========================================
  Hits         29958    29958           
  Misses       13811    13811           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4913f77]
Page Load Metrics (1282 ± 383 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint742641274823
domContentLoaded107626168
load6821391282798383
domInteractive107626168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 10, 2024
@sleepytanya sleepytanya changed the title add failing contract test: add scenario deploy failing contract Mar 10, 2024
@sleepytanya sleepytanya self-assigned this Mar 10, 2024
@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead release-11.11.3 Issue or pull request that will be included in release 11.11.3 labels Mar 10, 2024
@sleepytanya sleepytanya marked this pull request as ready for review March 10, 2024 17:09
@metamaskbot
Copy link
Collaborator

Builds ready [c839046]
Page Load Metrics (1463 ± 332 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint771871323115
domContentLoaded1374342110
load6221021463692332
domInteractive1374342110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya added release-11.3.0 Issue or pull request that will be included in release 11.3.0 release-11.13.0 Issue or pull request that will be included in release 11.13.0 and removed release-11.11.3 Issue or pull request that will be included in release 11.11.3 release-11.3.0 Issue or pull request that will be included in release 11.3.0 labels Mar 11, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [9b9e85a]
Page Load Metrics (1573 ± 419 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint782571334823
domContentLoaded11150343316
load6523441573872419
domInteractive11150343316
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya requested a review from segun March 16, 2024 05:02
Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleepytanya sleepytanya merged commit 8e6471f into develop Mar 19, 2024
64 of 66 checks passed
@sleepytanya sleepytanya deleted the add-deploy-failing-contract-test branch March 19, 2024 15:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
@metamaskbot metamaskbot added release-11.14.0 Issue or pull request that will be included in release 11.14.0 and removed release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Mar 19, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-11.13.0) on PR and removing other release labels (release-11.14.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Deploy failed contract, try to send failing transaction
4 participants