test: add scenario for personal sign using hardware wallet #23314

segun · 2024-03-05T12:33:38Z

Description

In this PR we add the scenario for the flow: eth sign with hardware wallet.
This task belongs to the effort of documenting manual QA flows in this Epic.

Related issues

Fixes: #22027

Manual testing steps

Check the video below.

Screenshots/Recordings

Performing the steps defined in the scenario

personal_sign.mov

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-05T12:33:51Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-03-05T12:35:31Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (0604181) to head (e64b8b2).
Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23314   +/-   ##
========================================
  Coverage    68.80%   68.80%           
========================================
  Files         1127     1127           
  Lines        43595    43595           
  Branches     11661    11661           
========================================
  Hits         29993    29993           
  Misses       13602    13602

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-03-05T12:40:35Z

Builds ready [d2770a6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1072 ± 462 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	78	294	169	67	32
		domContentLoaded	12	168	49	39	19
		load	64	2578	1072	963	462
		domInteractive	12	168	49	39	19

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

See comment

seaona · 2024-03-06T15:39:57Z

hey @segun the flow description looks good. I've seen that there is some csv formatting problem, since if I check the file, I don't see the table rendered.
See here.

If you check another file, you will see the table rendered. Ie.

This is likely caused by some comma missing or extra

metamaskbot · 2024-03-06T17:02:08Z

Builds ready [a376c30]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1145 ± 415 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	79	261	134	46	22
		domContentLoaded	14	80	35	22	10
		load	66	1981	1145	865	415
		domInteractive	14	79	35	22	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-03-07T07:33:43Z

Builds ready [d02049a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1144 ± 509 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	267	130	39	19
		domContentLoaded	14	74	29	15	7
		load	73	2501	1144	1059	509
		domInteractive	14	74	29	15	7

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

lgtm

metamaskbot · 2024-03-14T16:01:28Z

Builds ready [e64b8b2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (975 ± 435 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	236	123	38	18
		domContentLoaded	10	83	36	20	10
		load	61	2529	975	905	435
		domInteractive	10	83	36	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

segun requested a review from a team as a code owner March 5, 2024 12:33

segun self-assigned this Mar 5, 2024

segun added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 5, 2024

segun added the area-testSuite label Mar 5, 2024

seaona requested changes Mar 6, 2024

View reviewed changes

segun added 2 commits March 6, 2024 19:35

Personal sign test scenarios with hardware wallet

ce7f8fa

Fix formatting

a376c30

segun force-pushed the olu/personal-sign-hardware-wallet branch from d2770a6 to a376c30 Compare March 6, 2024 16:37

Merge branch 'develop' into olu/personal-sign-hardware-wallet

d02049a

segun added 2 commits March 12, 2024 16:20

Merge branch 'develop' into olu/personal-sign-hardware-wallet

a688f2b

Merge branch 'develop' into olu/personal-sign-hardware-wallet

5a31ce7

blackdevelopa approved these changes Mar 12, 2024

View reviewed changes

Merge branch 'develop' into olu/personal-sign-hardware-wallet

5f0020f

seaona self-requested a review March 14, 2024 15:36

seaona approved these changes Mar 14, 2024

View reviewed changes

Merge branch 'develop' into olu/personal-sign-hardware-wallet

e64b8b2

segun merged commit 9dfde3b into develop Mar 14, 2024
67 checks passed

segun deleted the olu/personal-sign-hardware-wallet branch March 14, 2024 16:35

github-actions bot locked and limited conversation to collaborators Mar 14, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2024

metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add scenario for personal sign using hardware wallet #23314

test: add scenario for personal sign using hardware wallet #23314

segun commented Mar 5, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 5, 2024

codecov bot commented Mar 5, 2024 •

edited

Loading

metamaskbot commented Mar 5, 2024

seaona left a comment

seaona commented Mar 6, 2024

metamaskbot commented Mar 6, 2024

metamaskbot commented Mar 7, 2024

seaona left a comment

metamaskbot commented Mar 14, 2024

test: add scenario for personal sign using hardware wallet #23314

test: add scenario for personal sign using hardware wallet #23314

Conversation

segun commented Mar 5, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 5, 2024

codecov bot commented Mar 5, 2024 • edited Loading

Codecov Report

metamaskbot commented Mar 5, 2024

seaona left a comment

Choose a reason for hiding this comment

seaona commented Mar 6, 2024

metamaskbot commented Mar 6, 2024

metamaskbot commented Mar 7, 2024

seaona left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 14, 2024

segun commented Mar 5, 2024 •

edited by github-actions bot

Loading

codecov bot commented Mar 5, 2024 •

edited

Loading