Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario set custom spending cap for custom token #23238

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Feb 29, 2024

Description

In this PR we add the scenario for the flow 'Set custom spending cap for custom token'.
This task belongs to the effort of documenting manual QA flows in this Epic.

Related issues

Fixes: #22411

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
    You can find rendered table here.

Screenshots/Recordings

1.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya requested a review from a team as a code owner February 29, 2024 04:38
Copy link
Contributor

github-actions bot commented Feb 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead release-11.12.0 Issue or pull request that will be included in release 11.12.0 labels Feb 29, 2024
@sleepytanya
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot
Copy link
Collaborator

Builds ready [66de225]
Page Load Metrics (818 ± 351 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint74167114199
domContentLoaded86132168
load501740818730351
domInteractive86132168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.61%. Comparing base (7f5595e) to head (6061a51).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23238   +/-   ##
========================================
  Coverage    68.61%   68.61%           
========================================
  Files         1098     1098           
  Lines        43101    43101           
  Branches     11513    11513           
========================================
  Hits         29571    29571           
  Misses       13530    13530           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [cfca0ba]
Page Load Metrics (1405 ± 322 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint822301284321
domContentLoaded1481372311
load6518841405672322
domInteractive1481372311
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@hjetpoluru hjetpoluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@metamaskbot
Copy link
Collaborator

Builds ready [6061a51]
Page Load Metrics (1710 ± 700 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint913732158440
domContentLoaded17177624019
load87375417101457700
domInteractive17177624019
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya merged commit 5850ee6 into develop Mar 1, 2024
67 checks passed
@sleepytanya sleepytanya deleted the test-scenario-set-custom-spending-cap branch March 1, 2024 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Mar 1, 2024
@metamaskbot metamaskbot removed the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Mar 13, 2024
@metamaskbot
Copy link
Collaborator

More than one release label on PR. Keeping the lowest one (release-11.12.0) on PR and removing other release labels (release-11.13.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set custom spending cap for custom token
4 participants