Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario check "customize transaction nonce" toggle works correctly. #23413

Closed
wants to merge 2 commits into from

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Mar 11, 2024

Description

In this PR we add the scenario for the flow 'Check "Customize transaction nonce works correctly'.
This task belongs to the effort of documenting manual QA flows in this Epic.

Open in GitHub Codespaces

Related issues

Fixes: 21989

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
    You can find rendered table here.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya requested a review from a team as a code owner March 11, 2024 04:21
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.72%. Comparing base (d980602) to head (dbde739).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23413   +/-   ##
========================================
  Coverage    68.71%   68.72%           
========================================
  Files         1105     1105           
  Lines        43250    43250           
  Branches     11562    11562           
========================================
+ Hits         29719    29720    +1     
+ Misses       13531    13530    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 11, 2024
@sleepytanya sleepytanya self-assigned this Mar 11, 2024
@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead release-11.13.0 Issue or pull request that will be included in release 11.13.0 labels Mar 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.13.0 Issue or pull request that will be included in release 11.13.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced settings: Check “Customize transaction nonce” toggle works correctly
2 participants