Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add scenario navigate through multiple unapproved transactions. #23569

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

sleepytanya
Copy link
Contributor

@sleepytanya sleepytanya commented Mar 19, 2024

Description

In this PR we add the scenario for the flow 'Navigate through multiple unapproved transactions, approve and reject individually, reject all at once'.
This task belongs to the effort of documenting manual QA flows in this Epic.

Open in GitHub Codespaces

Related issues

Fixes: 22410

Manual testing steps

  1. Verify that the test steps align with the sequence in the video.
  2. You can find rendered table here.

Screenshots/Recordings

multipleTx.mov

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sleepytanya sleepytanya added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Mar 19, 2024
@sleepytanya sleepytanya self-assigned this Mar 19, 2024
@sleepytanya sleepytanya requested a review from a team as a code owner March 19, 2024 02:13
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [f28926a]
Page Load Metrics (1318 ± 491 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint702491334823
domContentLoaded1184332110
load49251413181023491
domInteractive1084332110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sleepytanya sleepytanya merged commit 947e05f into develop Mar 19, 2024
63 of 64 checks passed
@sleepytanya sleepytanya deleted the navigate-multiple-transactions branch March 19, 2024 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.14.0 Issue or pull request that will be included in release 11.14.0 team-confirmations-system DEPRECATED: please use "team-confirmations" label instead
Projects
Archived in project
4 participants