test: add scenario for eth sign using hardware wallet #23313

segun · 2024-03-05T11:21:46Z

Description

In this PR we add the scenario for the flow: eth sign with hardware wallet.
This task belongs to the effort of documenting manual QA flows in this Epic.

Related issues

Fixes: #22026

Manual testing steps

Check the video below.

Screenshots/Recordings

Performing the steps defined in the scenario

eth_sign_ledger.mov

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-03-05T11:21:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

seaona · 2024-03-06T15:36:36Z

hey @segun the flow description looks good. I've seen that there's some csv formatting problem, since if I check the file, I don't see the table rendered.
See here.

If you check another file, you will see the table rendered. Ie.

This is likely caused by some comma missing or extra

seaona

See comment

codecov · 2024-03-06T16:54:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (5222d6f) to head (f173ee3).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #23313   +/-   ##
========================================
  Coverage    68.45%   68.45%           
========================================
  Files         1140     1140           
  Lines        43757    43757           
  Branches     11722    11722           
========================================
  Hits         29950    29950           
  Misses       13807    13807

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-03-06T17:00:31Z

Builds ready [17f51e5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1313 ± 433 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	250	145	51	25
		domContentLoaded	16	85	34	19	9
		load	72	2401	1313	902	433
		domInteractive	16	85	34	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

blackdevelopa

Looks good. The csv is formatted as expected

metamaskbot · 2024-03-12T20:12:52Z

Builds ready [0dd6eb8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1599 ± 239 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	72	192	140	30	14
		domContentLoaded	11	70	33	19	9
		load	127	1918	1599	498	239
		domInteractive	11	70	33	19	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

test/scenarios/13. sign/eth sign with hardware wallet.csv

metamaskbot · 2024-03-14T16:59:21Z

Builds ready [6dbbe7e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (967 ± 390 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	215	118	34	16
		domContentLoaded	9	63	31	18	9
		load	51	2107	967	812	390
		domInteractive	9	63	31	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

seaona

LGTM

metamaskbot · 2024-03-18T13:43:59Z

Builds ready [f173ee3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1032 ± 466 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	245	120	48	23
		domContentLoaded	9	68	27	20	10
		load	52	2543	1032	970	466
		domInteractive	9	68	27	20	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

segun added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 5, 2024

segun self-assigned this Mar 5, 2024

segun requested a review from a team as a code owner March 5, 2024 11:21

legobeat added the area-testSuite label Mar 5, 2024

seaona requested changes Mar 6, 2024

View reviewed changes

segun force-pushed the olu/test-scenario-eth-sign branch 2 times, most recently from 06010d6 to 393e337 Compare March 6, 2024 16:30

blackdevelopa previously approved these changes Mar 12, 2024

View reviewed changes

jpuri approved these changes Mar 13, 2024

View reviewed changes

jpuri previously approved these changes Mar 13, 2024

View reviewed changes

seaona reviewed Mar 14, 2024

View reviewed changes

test/scenarios/13. sign/eth sign with hardware wallet.csv Outdated Show resolved Hide resolved

segun added 5 commits March 14, 2024 18:40

Test scenario for eth sign hardware wallet.

22d43ba

Fix formatting

0e63e38

Fix formatting

40e2ec2

Fix formatting

28b9724

Fix step 16

a857216

segun dismissed stale reviews from jpuri and blackdevelopa via a857216 March 14, 2024 15:41

segun force-pushed the olu/test-scenario-eth-sign branch from 0dd6eb8 to a857216 Compare March 14, 2024 15:41

Merge branch 'develop' into olu/test-scenario-eth-sign

6dbbe7e

Merge branch 'develop' into olu/test-scenario-eth-sign

19ca237

seaona approved these changes Mar 15, 2024

View reviewed changes

sleepytanya approved these changes Mar 16, 2024

View reviewed changes

segun requested review from jpuri and blackdevelopa March 18, 2024 08:40

segun added 2 commits March 18, 2024 11:41

Merge branch 'develop' into olu/test-scenario-eth-sign

e717939

Merge branch 'develop' into olu/test-scenario-eth-sign

f173ee3

segun merged commit 00828da into develop Mar 18, 2024
66 checks passed

segun deleted the olu/test-scenario-eth-sign branch March 18, 2024 15:01

github-actions bot locked and limited conversation to collaborators Mar 18, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 18, 2024

metamaskbot added the release-11.14.0 Issue or pull request that will be included in release 11.14.0 label Mar 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add scenario for eth sign using hardware wallet #23313

test: add scenario for eth sign using hardware wallet #23313

segun commented Mar 5, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 5, 2024

seaona commented Mar 6, 2024 •

edited

Loading

seaona left a comment

codecov bot commented Mar 6, 2024 •

edited

Loading

metamaskbot commented Mar 6, 2024

blackdevelopa left a comment

metamaskbot commented Mar 12, 2024

metamaskbot commented Mar 14, 2024

seaona left a comment

metamaskbot commented Mar 18, 2024

test: add scenario for eth sign using hardware wallet #23313

test: add scenario for eth sign using hardware wallet #23313

Conversation

segun commented Mar 5, 2024 • edited by github-actions bot Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 5, 2024

seaona commented Mar 6, 2024 • edited Loading

seaona left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 6, 2024 • edited Loading

Codecov Report

metamaskbot commented Mar 6, 2024

blackdevelopa left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 12, 2024

metamaskbot commented Mar 14, 2024

seaona left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 18, 2024

segun commented Mar 5, 2024 •

edited by github-actions bot

Loading

seaona commented Mar 6, 2024 •

edited

Loading

codecov bot commented Mar 6, 2024 •

edited

Loading