fix(varlogtest): log stream appender returns missing errors in the callback

[ijsong]

What this PR does

This PR fixed the log stream appender's bug in the varlogtest package. It had
the bug that the callback in the log stream appender didn't return an error.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553
              • PR feat(all): change type of ClusterID from uint32 to int32 #566
                • PR refactor(all): make cluster id flag common #567
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594 👈
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (73d6a91) 61.14% compared to head (9d0b203) 61.16%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                     Coverage Diff                      @@
##           varlogtest_add_logstream     #594      +/-   ##
============================================================
+ Coverage                     61.14%   61.16%   +0.02%     
============================================================
  Files                           144      144              
  Lines                         19217    19217              
============================================================
+ Hits                          11751    11755       +4     
+ Misses                         6881     6874       -7     
- Partials                        585      588       +3     

Files	Coverage Δ
pkg/varlogtest/log.go	71.64% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.