refactor(all): make cluster id flag common

[ijsong]

No description provided.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553
              • PR feat(all): change type of ClusterID from uint32 to int32 #566
                • PR refactor(all): make cluster id flag common #567 👈
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.19% ⚠️

Comparison is base (500a4bb) 61.29% compared to head (3953081) 61.10%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           clusterid_int32     #567      +/-   ##
===================================================
- Coverage            61.29%   61.10%   -0.19%     
===================================================
  Files                  143      143              
  Lines                19081    19083       +2     
===================================================
- Hits                 11695    11661      -34     
- Misses                6815     6845      +30     
- Partials               571      577       +6     

Files Changed	Coverage Δ
internal/flags/cluster.go	50.00% <0.00%> (-50.00%)	⬇️
internal/flags/flags.go	0.00% <ø> (ø)
pkg/mrc/mrconnector/config.go	80.00% <ø> (ø)
pkg/types/types.go	57.14% <0.00%> (-1.40%)	⬇️
internal/admin/config.go	85.85% <100.00%> (ø)
internal/metarepos/config.go	67.30% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.