Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(varlogtest): add functional options to varlogtest #582

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Sep 11, 2023

What this PR does

This PR adds functional options to the varlogtest.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Patch coverage: 72.09% and project coverage change: +0.12% 🎉

Comparison is base (ea728eb) 61.02% compared to head (3df49ac) 61.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           clusterid_refactor     #582      +/-   ##
======================================================
+ Coverage               61.02%   61.15%   +0.12%     
======================================================
  Files                     143      144       +1     
  Lines                   19083    19115      +32     
======================================================
+ Hits                    11646    11689      +43     
+ Misses                   6855     6843      -12     
- Partials                  582      583       +1     
Files Changed Coverage Δ
pkg/varlogtest/config.go 68.96% <68.96%> (ø)
pkg/varlogtest/varlogtest.go 89.53% <78.57%> (-3.24%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong
Copy link
Member Author

ijsong commented Oct 4, 2023

Merge Activity

  • Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
  • Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.

Base automatically changed from clusterid_refactor to main October 4, 2023 07:32
@ijsong ijsong merged commit eb8a96f into main Oct 4, 2023
@ijsong ijsong deleted the varlogtest_functional_option branch October 4, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants