refactor(admin): prevent large lock from internal/admin.(*Admin)

[ijsong]

What this PR does

This PR prevents the large lock from internal/admin.(*Admin). Concretely it changes the role of internal/admin.(*Admin).mu from the single huge lock to guarding the fields such as lis, serverAddr, and closed.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553
              • PR feat(all): change type of ClusterID from uint32 to int32 #566
                • PR refactor(all): make cluster id flag common #567
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559 👈

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a18b285) 61.20% compared to head (94be0e7) 61.15%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                         Coverage Diff                         @@
##           admin_mrmanager_check_repfactor     #559      +/-   ##
===================================================================
- Coverage                            61.20%   61.15%   -0.05%     
===================================================================
  Files                                  144      144              
  Lines                                19243    19185      -58     
===================================================================
- Hits                                 11777    11733      -44     
+ Misses                                6878     6861      -17     
- Partials                               588      591       +3     

Files	Coverage Δ
internal/admin/admin.go	61.44% <38.88%> (-0.15%)	⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 5:10 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 5:11 AM: @ijsong merged this pull request with Graphite.