feat(all): change type of ClusterID from uint32 to int32

[ijsong]

No description provided.

[ijsong]

Current dependencies on/for this PR:

• main
  • PR build(go): use go 1.21 #585
    • PR ci(lint): use specific version for golaingci-lint rather than latest #586
      • PR fix(admin): refresh cluster metadata while adding storage node #558
        • PR test(e2e): use zaptest logger #557
          • PR feat(all): add gogoproto codec to grpc servers #581
            • PR refactor: add the standard flag --replication-factor #553
              • PR feat(all): change type of ClusterID from uint32 to int32 #566 👈
                • PR refactor(all): make cluster id flag common #567
                  • PR feat(varlogtest): add functional options to varlogtest #582
                  • PR feat(varlogtest): add initial metadata repository and support fetch APIs #583
                  • PR feat(varlogtest): create new instance of admin and log #591
                  • PR fix(varlogtest): validate log stream descriptor to create it #593
                  • PR fix(varlogtest): log stream appender returns missing errors in the callback #594
                  • PR fix(varlogtest): log stream appender can be closed in the callback #595
              • PR refactor(admin): prevent the large lock from mrmanager #554
                • PR feat(admin): check cluster id in mrmanager #555
                  • PR feat(admin): check replication factor in mrmanager #556
                  • PR refactor(admin): prevent large lock from internal/admin.(*Admin) #559

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.18% 🎉

Comparison is base (4b505b6) 61.10% compared to head (500a4bb) 61.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@                          Coverage Diff                          @@
##           common_repfactor_from_uint_to_int     #566      +/-   ##
=====================================================================
+ Coverage                              61.10%   61.29%   +0.18%     
=====================================================================
  Files                                    143      143              
  Lines                                  19081    19081              
=====================================================================
+ Hits                                   11660    11695      +35     
+ Misses                                  6841     6815      -26     
+ Partials                                 580      571       -9     

Files Changed	Coverage Δ
pkg/types/types.go	58.53% <0.00%> (ø)
internal/metarepos/config.go	67.30% <100.00%> (ø)
internal/storagenode/volume/volume.go	94.38% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ijsong]

Merge Activity

• Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
• Oct 4, 3:32 AM: @ijsong merged this pull request with Graphite.