Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): use zaptest logger #557

Merged
merged 1 commit into from
Oct 4, 2023
Merged

test(e2e): use zaptest logger #557

merged 1 commit into from
Oct 4, 2023

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Jul 31, 2023

No description provided.

@ijsong ijsong requested a review from hungryjang as a code owner July 31, 2023 14:09
@ijsong ijsong self-assigned this Jul 31, 2023
@ijsong ijsong changed the base branch from main to fix_e2e_add_sn_callagain July 31, 2023 14:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.11% ⚠️

Comparison is base (a2e0326) 61.78% compared to head (e2d1a05) 61.68%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           fix_e2e_add_sn_callagain     #557      +/-   ##
============================================================
- Coverage                     61.78%   61.68%   -0.11%     
============================================================
  Files                           138      138              
  Lines                         18879    18879              
============================================================
- Hits                          11664    11645      -19     
- Misses                         6637     6654      +17     
- Partials                        578      580       +2     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the fix_e2e_add_sn_callagain branch from 342598c to 631b652 Compare July 31, 2023 15:01
@ijsong ijsong force-pushed the fix_e2e_add_sn_callagain branch from 631b652 to f9cf795 Compare August 1, 2023 08:58
@ijsong ijsong force-pushed the fix_e2e_add_sn_callagain branch from f9cf795 to ae85448 Compare September 11, 2023 12:49
@ijsong ijsong force-pushed the fix_e2e_add_sn_callagain branch from ae85448 to c639834 Compare September 25, 2023 09:57
@ijsong
Copy link
Member Author

ijsong commented Oct 4, 2023

Merge Activity

  • Oct 4, 3:30 AM: @ijsong started a stack merge that includes this pull request via Graphite.
  • Oct 4, 3:31 AM: @ijsong merged this pull request with Graphite.

Base automatically changed from fix_e2e_add_sn_callagain to main October 4, 2023 07:31
@ijsong ijsong merged commit 2da8f76 into main Oct 4, 2023
@ijsong ijsong deleted the ee_test_logger branch October 4, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants