-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate op related methods from AssetExecutionContext #19441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2024
Merged
Closed
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 26, 2024 21:10
89a8183
to
18ea636
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 26, 2024 21:10
a3d08de
to
3d0b0dd
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 29, 2024 15:39
18ea636
to
8c9a9a4
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 29, 2024 15:39
3d0b0dd
to
3a80f77
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 29, 2024 16:31
8c9a9a4
to
704199e
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 29, 2024 16:31
3a80f77
to
0e38e81
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 29, 2024 17:27
704199e
to
4a1d2c0
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 29, 2024 17:27
0e38e81
to
4306c96
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 29, 2024 18:16
4a1d2c0
to
84e5e74
Compare
jamiedemaria
requested review from
alangenfeld,
sryza,
smackesey,
yuhan and
schrockn
and removed request for
schrockn
January 29, 2024 21:55
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 30, 2024 14:47
544d4f1
to
c26dce7
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 30, 2024 14:47
d29a995
to
864fe46
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 30, 2024 15:27
c26dce7
to
57c1d82
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
2 times, most recently
from
January 30, 2024 15:32
48d504d
to
0b1da2b
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 30, 2024 17:22
6c00ae5
to
eebfdd0
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 30, 2024 17:22
0b1da2b
to
25611bd
Compare
schrockn
approved these changes
Jan 30, 2024
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 30, 2024 20:19
eebfdd0
to
13fcbe7
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 30, 2024 20:19
25611bd
to
438f931
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 31, 2024 16:37
13fcbe7
to
a564e01
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 31, 2024 16:37
438f931
to
35435e5
Compare
jamiedemaria
force-pushed
the
jamie/partition-deprecation-docs
branch
from
January 31, 2024 17:55
a564e01
to
67a496b
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 31, 2024 17:55
35435e5
to
5df36d9
Compare
jamiedemaria
force-pushed
the
jamie/op-deprecations
branch
from
January 31, 2024 18:27
5df36d9
to
446b77c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Since we are wrapping up active work on the AssetExecutionContext for now, there are a couple of easy deprecations i'd like to get in that will improve user experience until we can more actively work on API development.
This PR deprecates the following methods in favor of accessing them through the
op_execution_context
:op_config
node_handle
op_handle
op
get_mapping_key
selected_output_names
How I Tested These Changes