Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate op related methods from AssetExecutionContext #19441

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Jan 26, 2024

Summary & Motivation

Since we are wrapping up active work on the AssetExecutionContext for now, there are a couple of easy deprecations i'd like to get in that will improve user experience until we can more actively work on API development.

This PR deprecates the following methods in favor of accessing them through the op_execution_context:
op_config
node_handle
op_handle
op
get_mapping_key
selected_output_names

How I Tested These Changes

This was referenced Jan 26, 2024
@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Jan 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 89a8183 to 18ea636 Compare January 26, 2024 21:10
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from a3d08de to 3d0b0dd Compare January 26, 2024 21:10
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 18ea636 to 8c9a9a4 Compare January 29, 2024 15:39
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 3d0b0dd to 3a80f77 Compare January 29, 2024 15:39
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 8c9a9a4 to 704199e Compare January 29, 2024 16:31
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 3a80f77 to 0e38e81 Compare January 29, 2024 16:31
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 704199e to 4a1d2c0 Compare January 29, 2024 17:27
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 0e38e81 to 4306c96 Compare January 29, 2024 17:27
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 4a1d2c0 to 84e5e74 Compare January 29, 2024 18:16
@jamiedemaria jamiedemaria requested review from alangenfeld, sryza, smackesey, yuhan and schrockn and removed request for schrockn January 29, 2024 21:55
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 544d4f1 to c26dce7 Compare January 30, 2024 14:47
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from d29a995 to 864fe46 Compare January 30, 2024 14:47
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from c26dce7 to 57c1d82 Compare January 30, 2024 15:27
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch 2 times, most recently from 48d504d to 0b1da2b Compare January 30, 2024 15:32
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 6c00ae5 to eebfdd0 Compare January 30, 2024 17:22
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 0b1da2b to 25611bd Compare January 30, 2024 17:22
@erinkcochran87 erinkcochran87 removed their request for review January 30, 2024 17:50
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from eebfdd0 to 13fcbe7 Compare January 30, 2024 20:19
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 25611bd to 438f931 Compare January 30, 2024 20:19
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from 13fcbe7 to a564e01 Compare January 31, 2024 16:37
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 438f931 to 35435e5 Compare January 31, 2024 16:37
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecation-docs branch from a564e01 to 67a496b Compare January 31, 2024 17:55
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 35435e5 to 5df36d9 Compare January 31, 2024 17:55
Base automatically changed from jamie/partition-deprecation-docs to master January 31, 2024 18:26
@jamiedemaria jamiedemaria force-pushed the jamie/op-deprecations branch from 5df36d9 to 446b77c Compare January 31, 2024 18:27
@jamiedemaria jamiedemaria merged commit 1e6e187 into master Jan 31, 2024
2 checks passed
@jamiedemaria jamiedemaria deleted the jamie/op-deprecations branch January 31, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants