-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prototype] AssetExecutionContext partition methods given as named tuple #19037
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2024
Merged
jamiedemaria
force-pushed
the
jamie/partition-methods-asset-key-based
branch
from
January 10, 2024 17:13
97d5e6f
to
f062952
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 10, 2024 17:13
dbd4f00
to
90ceb0f
Compare
jamiedemaria
force-pushed
the
jamie/partition-methods-asset-key-based
branch
from
January 12, 2024 19:48
f062952
to
5331a95
Compare
jamiedemaria
changed the base branch from
jamie/partition-methods-asset-key-based
to
jamie/partition-example-base
January 12, 2024 19:49
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 12, 2024 19:49
90ceb0f
to
e705b81
Compare
jamiedemaria
commented
Jan 12, 2024
@@ -33,7 +33,7 @@ def relativedelta(*args, **kwargs): | |||
metadata={"partition_expr": "LastModifiedDate"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file will not get merged. It's an example of what some of these apis will look like in use
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 16, 2024 17:37
b0e7745
to
215fed9
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 16, 2024 17:37
0709c1d
to
085a52b
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 16, 2024 18:15
215fed9
to
38b66f9
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 16, 2024 18:15
085a52b
to
b648934
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 17, 2024 21:13
38b66f9
to
50c80ab
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 17, 2024 21:13
373ee36
to
e3ac323
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 18, 2024 15:55
50c80ab
to
1fee854
Compare
This was referenced Jan 26, 2024
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 26, 2024 20:05
04fd627
to
0e1fc3e
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 26, 2024 20:05
3d4bed9
to
ab9a9eb
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 15:39
0e1fc3e
to
dc6edf0
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 29, 2024 15:39
ab9a9eb
to
a44e758
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 16:30
dc6edf0
to
ccc4260
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 29, 2024 16:30
a44e758
to
0fa4a8f
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 17:26
ccc4260
to
f416c05
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 29, 2024 17:26
0fa4a8f
to
25083e3
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 18:16
f416c05
to
51d46aa
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 29, 2024 18:16
25083e3
to
e285806
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 19:44
51d46aa
to
2670364
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 29, 2024 19:45
e285806
to
fc01971
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 20:03
2670364
to
2660075
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 29, 2024 20:03
fc01971
to
5086c16
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 30, 2024 17:23
2660075
to
a5828e1
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 30, 2024 17:23
5086c16
to
d6268c3
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 30, 2024 20:19
a5828e1
to
f5be566
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-2
branch
from
January 30, 2024 20:19
d6268c3
to
c2da8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR is a prototype for a potential API for partition methods on the
AssetExecutionContext
. Rather than fetching individual properties about the partition from different methods, the user will fetch aPartitionInfo
(name tbd) object from the context that will contain the relevant partition properties.Hooli PR - dagster-io/hooli-data-eng-pipelines#58
DOP PR - https://github.com/dagster-io/internal/pull/7902
issues with this API design:
time_window
on thePartitionInfo
named tuple needs to be an optional field so that static partitions can have it set toNone
. this causes some linting errors in the code base when you want to access thestart
orend
properties of the time window since the retrievedtime_window
may beNone
How I Tested These Changes