-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wip] two execution contexts with minimal changes #18543
Closed
jamiedemaria
wants to merge
27
commits into
jamie/upstream-materialization-event
from
jamie/two-contexts
Closed
[wip] two execution contexts with minimal changes #18543
jamiedemaria
wants to merge
27
commits into
jamie/upstream-materialization-event
from
jamie/two-contexts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 6, 2023
Merged
jamiedemaria
force-pushed
the
jamie/asset-context-deprecation-setup
branch
from
December 6, 2023 20:23
842b470
to
553b248
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 6, 2023 20:23
231d32d
to
6bc3236
Compare
jamiedemaria
force-pushed
the
jamie/asset-context-deprecation-setup
branch
from
December 6, 2023 21:13
553b248
to
e7e7de8
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 6, 2023 21:13
6bc3236
to
5d2ef81
Compare
jamiedemaria
commented
Dec 6, 2023
@@ -36,9 +36,18 @@ | |||
from dagster._utils import is_named_tuple_instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this file - just notes for me
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 6, 2023 23:35
5d2ef81
to
4ea1df7
Compare
jamiedemaria
changed the base branch from
jamie/asset-context-deprecation-setup
to
jamie/asset-di
December 6, 2023 23:35
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 6, 2023 23:42
1247272
to
ca5f755
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 6, 2023 23:42
4ea1df7
to
9683498
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 7, 2023 19:56
ca5f755
to
b845df7
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 7, 2023 19:56
9683498
to
b38c16d
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 7, 2023 20:02
b845df7
to
11d446a
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 7, 2023 20:02
b38c16d
to
af05c09
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 7, 2023 20:19
11d446a
to
8fcb99f
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 7, 2023 20:19
af05c09
to
a39a021
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 7, 2023 20:29
8fcb99f
to
a060f2b
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 7, 2023 20:29
a39a021
to
552d793
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 7, 2023 20:53
a060f2b
to
8328998
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 7, 2023 20:53
552d793
to
7a7a7e0
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
December 7, 2023 21:26
8328998
to
42a4ac0
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
December 7, 2023 21:26
7a7a7e0
to
50e56e0
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 30, 2024 20:19
401ba83
to
54cf22d
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
January 30, 2024 20:19
81f918d
to
9b0b9db
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
2 times, most recently
from
February 2, 2024 19:51
ac6877e
to
d572c35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
With the deprecation of methods on
AssetExecutionContext
, several places in the main execution path will start throwing warnings. This PR prevents those warnings from being thrown by pulling the op execution context out of the asset execution context. We may want to implement a different solution eventually, but this will suffice for now and will act as a marker of all the places where the context is used in the main execution path.How I Tested These Changes