Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] two execution contexts with minimal changes #18543

Closed

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Dec 6, 2023

Summary & Motivation

With the deprecation of methods on AssetExecutionContext, several places in the main execution path will start throwing warnings. This PR prevents those warnings from being thrown by pulling the op execution context out of the asset execution context. We may want to implement a different solution eventually, but this will suffice for now and will act as a marker of all the places where the context is used in the main execution path.

How I Tested These Changes

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Dec 6, 2023

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@@ -36,9 +36,18 @@
from dagster._utils import is_named_tuple_instance
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this file - just notes for me

@jamiedemaria jamiedemaria changed the base branch from jamie/asset-context-deprecation-setup to jamie/asset-di December 6, 2023 23:35
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 401ba83 to 54cf22d Compare January 30, 2024 20:19
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch 2 times, most recently from ac6877e to d572c35 Compare February 2, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant