-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make upstream asset materialization events available on the context #18971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2024
Merged
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
January 2, 2024 21:22
48e6d71
to
1f63bc8
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 2, 2024 21:22
64575b6
to
41bf876
Compare
jamiedemaria
force-pushed
the
jamie/two-contexts
branch
from
January 2, 2024 21:51
1f63bc8
to
7fe3c2d
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
2 times, most recently
from
January 3, 2024 00:07
f445590
to
6b030e7
Compare
jamiedemaria
changed the base branch from
jamie/two-contexts
to
jamie/asset-di
January 3, 2024 00:07
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 4, 2024 19:06
266f952
to
efaa64d
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 4, 2024 19:06
6b030e7
to
310782a
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 10, 2024 17:13
efaa64d
to
c0f59d6
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 10, 2024 17:13
310782a
to
3e05391
Compare
jamiedemaria
requested review from
schrockn,
alangenfeld,
smackesey and
yuhan
January 12, 2024 17:12
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 12, 2024 19:48
c0f59d6
to
6675f38
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 12, 2024 19:48
3e05391
to
2149c6b
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 29, 2024 15:39
1a898dc
to
8a9101d
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 29, 2024 16:30
b56761f
to
8891731
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 29, 2024 16:30
8a9101d
to
78b26d0
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 29, 2024 17:26
8891731
to
7581aea
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 29, 2024 17:26
78b26d0
to
8f6eaf6
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 29, 2024 18:16
7581aea
to
f1a29e0
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 29, 2024 18:16
8f6eaf6
to
19af7e7
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 29, 2024 19:44
f1a29e0
to
f05054c
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 29, 2024 19:44
19af7e7
to
46fd5ab
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 29, 2024 20:03
f05054c
to
03fc95f
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
2 times, most recently
from
January 30, 2024 17:22
2f64efa
to
401ba83
Compare
jamiedemaria
force-pushed
the
jamie/asset-di
branch
from
January 30, 2024 20:19
3f60787
to
63e5bc6
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 30, 2024 20:19
401ba83
to
54cf22d
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
January 31, 2024 21:57
54cf22d
to
ac6877e
Compare
jamiedemaria
force-pushed
the
jamie/upstream-materialization-event
branch
from
February 2, 2024 19:51
ac6877e
to
d572c35
Compare
converting back to draft to get this out of review queues until context work is re-prioritized |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The data provenance/versioning feature already fetches the latest
AssetMaterialization
for the upstream assets for an asset that is materializing. This PR saves thoseAssetMaterialization
s and provides a context method to fetch theAssetMaterialization
for an upstream asset. This will allow users to get the metadata attached to an upstream asset, among other properties.How I Tested These Changes