Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upstream asset materialization events available on the context #18971

Closed
wants to merge 8 commits into from

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Jan 2, 2024

Summary & Motivation

The data provenance/versioning feature already fetches the latest AssetMaterialization for the upstream assets for an asset that is materializing. This PR saves those AssetMaterializations and provides a context method to fetch the AssetMaterialization for an upstream asset. This will allow users to get the metadata attached to an upstream asset, among other properties.

How I Tested These Changes

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Jan 2, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 64575b6 to 41bf876 Compare January 2, 2024 21:22
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch 2 times, most recently from f445590 to 6b030e7 Compare January 3, 2024 00:07
@jamiedemaria jamiedemaria changed the base branch from jamie/two-contexts to jamie/asset-di January 3, 2024 00:07
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 6b030e7 to 310782a Compare January 4, 2024 19:06
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 310782a to 3e05391 Compare January 10, 2024 17:13
@jamiedemaria jamiedemaria marked this pull request as ready for review January 11, 2024 21:03
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 3e05391 to 2149c6b Compare January 12, 2024 19:48
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 1a898dc to 8a9101d Compare January 29, 2024 15:39
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 8a9101d to 78b26d0 Compare January 29, 2024 16:30
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 78b26d0 to 8f6eaf6 Compare January 29, 2024 17:26
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 8f6eaf6 to 19af7e7 Compare January 29, 2024 18:16
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 19af7e7 to 46fd5ab Compare January 29, 2024 19:44
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch 2 times, most recently from 2f64efa to 401ba83 Compare January 30, 2024 17:22
@erinkcochran87 erinkcochran87 removed their request for review January 30, 2024 17:47
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 401ba83 to 54cf22d Compare January 30, 2024 20:19
Base automatically changed from jamie/asset-di to master January 31, 2024 16:36
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from 54cf22d to ac6877e Compare January 31, 2024 21:57
@jamiedemaria jamiedemaria force-pushed the jamie/upstream-materialization-event branch from ac6877e to d572c35 Compare February 2, 2024 19:51
@jamiedemaria
Copy link
Contributor Author

converting back to draft to get this out of review queues until context work is re-prioritized

@jamiedemaria jamiedemaria marked this pull request as draft February 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants