-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate asset_partition_*_for_output on AssetExecutionContext #19436
Conversation
36dc1f0
to
f87462e
Compare
f5d0466
to
3159b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these get used frequently in docs, so we should make sure to fix those too before releasing this change.
We should also make sure that users don't hit deprecation warnings when they invoke non-deprecated methods that invoke these deprecated methods under the covers. |
docs PR #19437
|
b56761f
to
8891731
Compare
543f259
to
a0bec89
Compare
8891731
to
7581aea
Compare
a0bec89
to
13188c8
Compare
7581aea
to
f1a29e0
Compare
13188c8
to
d959fea
Compare
f1a29e0
to
f05054c
Compare
d959fea
to
2e87b22
Compare
f05054c
to
03fc95f
Compare
1223f1b
to
0f413ec
Compare
0f413ec
to
8380ab3
Compare
9e9c35d
to
21389f3
Compare
3f60787
to
63e5bc6
Compare
21389f3
to
2a69ae3
Compare
2a69ae3
to
0fc1636
Compare
Summary & Motivation
Since we are wrapping up active work on the AssetExecutionContext for now, there are a couple of easy deprecations we'd like to get in that will improve user experience until we can more actively work on API development.
This PR deprecates the following methods in favor of:
asset_partition_key_for_output
->partition_key
asset_partition_keys_for_output
->partition_keys
asset_partitions_time_window_for_output
->partition_time_window
asset_partition_key_range_for_output
->partition_key_range
The majority of the changes in this PR are updating tests to use the non-deprecated APIs
How I Tested These Changes
updates unit tests