Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate asset_partition_*_for_output on AssetExecutionContext #19436

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Jan 26, 2024

Summary & Motivation

Since we are wrapping up active work on the AssetExecutionContext for now, there are a couple of easy deprecations we'd like to get in that will improve user experience until we can more actively work on API development.

This PR deprecates the following methods in favor of:
asset_partition_key_for_output -> partition_key
asset_partition_keys_for_output -> partition_keys
asset_partitions_time_window_for_output -> partition_time_window
asset_partition_key_range_for_output -> partition_key_range

The majority of the changes in this PR are updating tests to use the non-deprecated APIs

How I Tested These Changes

updates unit tests

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Jan 26, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these get used frequently in docs, so we should make sure to fix those too before releasing this change.

@sryza
Copy link
Contributor

sryza commented Jan 27, 2024

We should also make sure that users don't hit deprecation warnings when they invoke non-deprecated methods that invoke these deprecated methods under the covers.

@jamiedemaria
Copy link
Contributor Author

jamiedemaria commented Jan 29, 2024

docs PR #19437

We should also make sure that users don't hit deprecation warnings when they invoke non-deprecated methods that invoke these deprecated methods under the covers.

Good point. I don't know of any methods calling these methods but I will do a search just to make sure Edit: I grepped through the code base and didn't find any instances where other methods called these methods. so we should be good on this front

@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from 543f259 to a0bec89 Compare January 29, 2024 16:31
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from a0bec89 to 13188c8 Compare January 29, 2024 17:27
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from 13188c8 to d959fea Compare January 29, 2024 18:16
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from d959fea to 2e87b22 Compare January 29, 2024 19:44
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch 2 times, most recently from 1223f1b to 0f413ec Compare January 29, 2024 21:49
@jamiedemaria jamiedemaria changed the base branch from jamie/asset-di to jamie/asset-context-deprecation-setup January 29, 2024 21:49
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from 0f413ec to 8380ab3 Compare January 30, 2024 14:47
@jamiedemaria jamiedemaria changed the base branch from jamie/asset-context-deprecation-setup to jamie/asset-di January 30, 2024 14:47
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch 2 times, most recently from 9e9c35d to 21389f3 Compare January 30, 2024 17:22
@erinkcochran87 erinkcochran87 removed their request for review January 30, 2024 17:50
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from 21389f3 to 2a69ae3 Compare January 30, 2024 20:19
Base automatically changed from jamie/asset-di to master January 31, 2024 16:36
@jamiedemaria jamiedemaria force-pushed the jamie/partition-deprecations branch from 2a69ae3 to 0fc1636 Compare January 31, 2024 16:37
@jamiedemaria jamiedemaria merged commit b2b732b into master Jan 31, 2024
1 check passed
@jamiedemaria jamiedemaria deleted the jamie/partition-deprecations branch January 31, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants