-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prototype] sub-context for each upstream dependency #19283
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 18, 2024
Merged
This was referenced Jan 18, 2024
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 19, 2024 16:38
1fee854
to
558590d
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 19, 2024 16:38
675fc6d
to
725f11d
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 19, 2024 19:09
558590d
to
bcc9cab
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 19, 2024 19:09
725f11d
to
bc1343d
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 19, 2024 20:13
bcc9cab
to
af681dc
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 19, 2024 20:13
bc1343d
to
db5c97f
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 23, 2024 00:11
af681dc
to
3016287
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 23, 2024 00:11
db5c97f
to
79c9359
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 26, 2024 19:10
3016287
to
04fd627
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 26, 2024 19:11
79c9359
to
5711594
Compare
This was referenced Jan 26, 2024
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 26, 2024 20:05
04fd627
to
0e1fc3e
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 26, 2024 20:05
5711594
to
f62c24d
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 15:39
0e1fc3e
to
dc6edf0
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 29, 2024 15:39
f62c24d
to
fc4cb27
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 16:30
dc6edf0
to
ccc4260
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 29, 2024 16:30
fc4cb27
to
c4d000e
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 17:26
ccc4260
to
f416c05
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 29, 2024 17:26
c4d000e
to
d8cf9ea
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 18:16
f416c05
to
51d46aa
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 29, 2024 18:16
d8cf9ea
to
d185017
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 19:44
51d46aa
to
2670364
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 29, 2024 19:44
d185017
to
532ca5f
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 29, 2024 20:03
2670364
to
2660075
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 29, 2024 20:03
532ca5f
to
fc4ed8c
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 30, 2024 17:23
2660075
to
a5828e1
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 30, 2024 17:23
fc4ed8c
to
79d3238
Compare
jamiedemaria
force-pushed
the
jamie/partition-example-base
branch
from
January 30, 2024 20:19
a5828e1
to
f5be566
Compare
jamiedemaria
force-pushed
the
jamie/partition-api-4
branch
from
January 30, 2024 20:19
79d3238
to
d23210e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR is a prototype for a potential API for partition methods on the
AssetExecutionContext
. This version adds aDepContext
that contains various methods that are scoped to a particular upstream dependency, including partition methodsNo Hooli or DOP PR for this one since those repos just use partition methods for the currently materializing asset. They would look identical to the PRs for API 1 (Hooli PR - dagster-io/hooli-data-eng-pipelines#59 DOP PR - https://github.com/dagster-io/internal/pull/7903)
How I Tested These Changes