Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Wording update #9151

Merged
merged 6 commits into from
Dec 21, 2023
Merged

[CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Wording update #9151

merged 6 commits into from
Dec 21, 2023

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Dec 20, 2023 •
edited
Loading

Wording of Expectation Rendering update after review in Product channel.
Screenshot 2023-12-20 at 4 17 52 PM
Screenshot 2023-12-20 at 4 17 24 PM

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

@netlify Netlify
Copy link

netlify bot commented Dec 20, 2023 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit f326bcd
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65837f5b4ede870008606095
😎 Deploy Preview https://deploy-preview-9151.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinnnyshinshin Shinnnyshinshin changed the title [CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Referential Integrity (0.18 branch) #9145 [CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Referential Integrity - Wording update Dec 20, 2023
@Shinnnyshinshin Shinnnyshinshin changed the base branch from develop to 0.18.x December 20, 2023 23:57
@ghost
Copy link

ghost commented Dec 20, 2023 •
edited by ghost
Loading

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Shinnnyshinshin Shinnnyshinshin self-assigned this Dec 21, 2023
@Shinnnyshinshin Shinnnyshinshin changed the title [CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Referential Integrity - Wording update [CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Wording update Dec 21, 2023
JennyTee
JennyTee approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@JennyTee JennyTee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@Shinnnyshinshin @JennyTee
Update contrib/experimental/great_expectations_experimental/expectati…
7225866 
…ons/expect_column_values_to_be_present_in_other_table.py

Co-authored-by: JennyTee <[email protected]>
@Shinnnyshinshin Shinnnyshinshin added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@Shinnnyshinshin Shinnnyshinshin added this pull request to the merge queue Dec 21, 2023
Merged via the queue into 0.18.x with commit 3ff2c58 Dec 21, 2023
54 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the f/zel-243/zel-254/expectation-wording-update branch December 21, 2023 01:37
anthonyburdi
anthonyburdi reviewed Dec 21, 2023
View reviewed changes
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how this turned out!

@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Dec 23, 2023
Merged
4 tasks
This was referenced Jan 3, 2024
Merged
Merged
@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Jan 10, 2024
Merged
4 tasks
@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Jan 16, 2024
Merged
4 tasks
@cdkini cdkini mentioned this pull request Jan 19, 2024
Merged
4 tasks
This was referenced Feb 1, 2024
Closed
Closed
@cdkini cdkini mentioned this pull request Feb 13, 2024
Closed
4 tasks
This was referenced Feb 27, 2024
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Mar 19, 2024
Closed
4 tasks
@Shinnnyshinshin Shinnnyshinshin mentioned this pull request Apr 20, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyburdi anthonyburdi anthonyburdi left review comments

@JennyTee JennyTee JennyTee approved these changes

@NathanFarmer NathanFarmer NathanFarmer approved these changes

Assignees

@Shinnnyshinshin Shinnnyshinshin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shinnnyshinshin @anthonyburdi @NathanFarmer @JennyTee