[CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Interface Update #9165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shinnnyshinshin
commented
Dec 23, 2023
Comment on lines
-47
to
-50
| Also, the `template_dict` parameter we would use for the Expectation on `order_table_1` and `order_table_2` would | ||
| look like the following: | ||
|
|
||
| "template_dict" = { |
There was a problem hiding this comment.
cleaned this up since we no longer need to use template_dict
Shinnnyshinshin
commented
Dec 23, 2023
| query = """ | ||
| SELECT COUNT(1) FROM ( |
There was a problem hiding this comment.
Interesting enough, this was the only change that was needed to retrieve the full set of unexpected values
JennyTee
reviewed
Dec 26, 2023
| "out": { | ||
| "success": False, | ||
| "result": { | ||
| "observed_value": "2 missing valuess.", |
JennyTee
approved these changes
Dec 26, 2023
JennyTee
reviewed
Dec 26, 2023
| foreign_table: foreign table. | ||
| primary_key_column_in_foreign_table: key column for primary key in foreign table. | ||
| Args: | ||
| foreign_key_column: foreign key-column of current table that we want to validate. |
There was a problem hiding this comment.
Nit: we prob don't need to hyphenate key-column here since it's not hyphenated on line 56
This was referenced Jan 3, 2024
This was referenced Jan 10, 2024
Merged
4 tasks
This was referenced Feb 1, 2024
4 tasks
This was referenced Feb 27, 2024
This was referenced Mar 12, 2024
Merged
This was referenced Mar 15, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to interface after review
template_dictare now top-level parameters to Expectation.ValidatorandExpectationRegistrywhere we pass in the Expectation configuration whenever we load anexpectation_implementation(). I believe this is very minor over-head for being able to enable this functionality, but I'd be happy to discuss._diagnostic_unexpected_table_renderer, but only if the results actually have unexpected values.Successful validation without table
Unsuccessful validation with table
invoke lint(usesblack+ruff)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!