[FEATURE] MetricListMetricRetriever - 0.18.x #9615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f/zel-455/zel-488/metric-list-retriever-and-tests * f/zel-455/zel-488/cdm-code-moved-to-parent-class: from metrics_calculator
❌ Deploy Preview for niobium-lead-7998 failed.
|
4 tasks
rreinoldsc
reviewed
Mar 13, 2024
great_expectations/experimental/metric_repository/metric_list_metric_retriever.py
Show resolved
Hide resolved
rreinoldsc
reviewed
Mar 13, 2024
| exception=exception, | ||
| ) | ||
|
|
||
| def _get_table_column_types(self, batch_request: BatchRequest) -> Metric: |
rreinoldsc
reviewed
Mar 13, 2024
| exception=exception, | ||
| ) | ||
|
|
||
| def _get_table_columns(self, batch_request: BatchRequest) -> Metric: |
rreinoldsc
reviewed
Mar 13, 2024
| metrics.append(self._get_table_column_types(batch_request=batch_request)) | ||
| return metrics | ||
|
|
||
| def _get_table_row_count(self, batch_request: BatchRequest) -> Metric: |
Shinnnyshinshin
commented
Mar 13, 2024
Shinnnyshinshin
commented
Mar 13, 2024
Comment on lines
-81
to
-83
| self._get_table_row_count(batch_id, computed_metrics, aborted_metrics), | ||
| self._get_table_columns(batch_id, computed_metrics, aborted_metrics), | ||
| self._get_table_column_types(batch_id, computed_metrics, aborted_metrics), |
There was a problem hiding this comment.
This was moved to the metric_retriever.py parent class
rreinoldsc
reviewed
Mar 14, 2024
| metrics = metric_retriever.get_metrics( | ||
| batch_request=mock_batch_request, metric_list=cdm_metrics_list | ||
| ) | ||
| # why is this not sorted? |
There was a problem hiding this comment.
ha oops. This should go away
4 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Shinnnyshinshin
deleted the
f/zel-455/zel-488/metric-list-retriever-and-tests
branch
This was referenced Mar 15, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ColumnDescriptiveMetricsMetricRetrieverto parent class (0.18.x) #9612, which refactoredColumnDescriptiveMetricsMetricRetrievercode to parent class.MetricListMetricRetrieverand associated unit + integration tests.developwith identical changes.invoke lint(usesruff format+ruff check)