Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Parameter Rename #9180

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

Shinnnyshinshin
Copy link
Contributor

@Shinnnyshinshin Shinnnyshinshin commented Jan 3, 2024

  • Rename Parameter after feedback
  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 0d8bceb
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6595bbc06cb595000867cedc
😎 Deploy Preview https://deploy-preview-9180.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinnnyshinshin Shinnnyshinshin changed the base branch from develop to 0.18.x January 3, 2024 19:56
@Shinnnyshinshin Shinnnyshinshin self-assigned this Jan 3, 2024
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit to clean up the docstring description, otherwise LGTM!

…ons/expect_column_values_to_be_present_in_other_table.py

Co-authored-by: Anthony Burdi <[email protected]>
Copy link
Member

@anthonyburdi anthonyburdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making that tweak.

@ghost
Copy link

ghost commented Jan 3, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Shinnnyshinshin Shinnnyshinshin added this pull request to the merge queue Jan 3, 2024
Merged via the queue into 0.18.x with commit adf542a Jan 3, 2024
55 checks passed
@Shinnnyshinshin Shinnnyshinshin deleted the f/zel-243/zel-254/update-interface branch January 3, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants