Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Wording update #9151

Merged
merged 6 commits into from
Dec 21, 2023
Merged

[CONTRIB] ExpectColumnValuesToBePresentInOtherTable - Wording update #9151

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f326bcd
slight change to output after product review
Shinnnyshinshin Dec 20, 2023
9036b20
update
Shinnnyshinshin Dec 20, 2023
3156e65
pushing
Shinnnyshinshin Dec 21, 2023
774faaf
pushing small change to simplify
Shinnnyshinshin Dec 21, 2023
7225866
Update contrib/experimental/great_expectations_experimental/expectati…
Shinnnyshinshin Dec 21, 2023
be8d776
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...pectations_experimental/expectations/expect_column_values_to_be_present_in_other_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def _prescriptive_renderer(

template_dict = configuration.kwargs.get("template_dict")

template_str = "All values in column $foreign_key_column are present in column $primary_key_column_in_foreign_table of table $foreign_table. (Observed Value is the number of missing values)."
template_str = "All values in column $foreign_key_column are present in column $primary_key_column_in_foreign_table of table $foreign_table."

params = {
"foreign_key_column": template_dict["foreign_key_column"],
Expand Down Expand Up @@ -163,7 +163,10 @@ def _validate(
self._validate_template_dict(configuration)
final_value = metrics.get("query.template_values")[0]["COUNT(1)"]
return ExpectationValidationResult(
success=(final_value == 0), result={"observed_value": final_value}
success=(final_value == 0),
result={
"observed_value": f"{final_value} missing item{'s' if final_value != 1 else ''}"
},
)

examples = [
Expand Down