Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Delete test_run_multibatch_data_assistant_and_checkpoint #9128

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Dec 18, 2023

It appears that multibatch only works when temp tables are used. That is, we can toggle temp tables on and off and see this pass/fail. We are deleting this test since we don't officially support multibatch. If users are using this functionality, they can do one of 2 things:

  1. Explicitly turn temp tables on instead of using the default
  2. Use 0.18.5

@ghost
Copy link

ghost commented Dec 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 changed the title [skip ci][MAINTENANCE] Delete test_run_multibatch_data_assistant_and_checkpoint [MAINTENANCE] Delete test_run_multibatch_data_assistant_and_checkpoint Dec 18, 2023
@Kilo59 Kilo59 enabled auto-merge December 18, 2023 21:32
@Kilo59 Kilo59 requested a review from nicgrayson December 18, 2023 21:34
@Kilo59 Kilo59 added this pull request to the merge queue Dec 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2023
@Kilo59 Kilo59 added this pull request to the merge queue Dec 18, 2023
Merged via the queue into 0.18.x with commit 3349016 Dec 18, 2023
59 of 61 checks passed
@Kilo59 Kilo59 deleted the m/_/delete_multibatch_test branch December 18, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants