Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] 0.18.x cherrypick create_temp_tables fixes from develop #9124

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

Kilo59
Copy link
Contributor

@Kilo59 Kilo59 commented Dec 18, 2023

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Kilo59 and others added 2 commits December 18, 2023 14:44
…SQLAlchemyExecutionEngine` creation. (#9118)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@Kilo59 Kilo59 requested a review from roblim December 18, 2023 19:46
@ghost
Copy link

ghost commented Dec 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Kilo59 Kilo59 enabled auto-merge December 18, 2023 19:47
@Kilo59 Kilo59 changed the title [BUGFIX] Fix create_temp_tables [BUGFIX] 0.18.x cherrypick create_temp_tables fixes from develop Dec 18, 2023
@Kilo59 Kilo59 self-assigned this Dec 18, 2023
@nicgrayson nicgrayson disabled auto-merge December 18, 2023 19:54
@nicgrayson nicgrayson merged commit eb36875 into 0.18.x Dec 18, 2023
45 of 56 checks passed
@nicgrayson nicgrayson deleted the 0_18_x_temp_table_fixes branch December 18, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants