[BUGFIX] 0.18.4 - Fix Snowflake error when using alternative connection details format.

[Kilo59]

Copy of the V1 fix so that we can release as part of 0.18.4

• [BUGFIX] V1 - Fix Snowflake error when using alternative connection details format. #9055

Changes the behavior of SnowflakeDatasource.get_execution_engine() so that it no longer re-creates the sqlalchemy.engine.Engine object and instead re-uses the one used by the Datasource for .test_connection().

This solves 2 problems...

1. Reduces waste and extra connections caused by having 2 different sqlalchemy.engine.Engine objects at runtime.
2. Removes the problem of having slightly different configured sqlalchemy.engine.Engine objects.
   • This is the source of the bug that requires a new OSS release.

This is a more minimal version of the following bugfix. Issues with SQLite are forcing the more minimal PR (9055).

• [BUGFIX] re-use sa.engine.Engine object #9051

Other notes

For Snowflake this also means that when using the authenticator=externalbrowser query param, the browser will only need to auth once instead of 2wice for every connection.

[ghost]

👇 Click on the image for a new way to code review

Legend