Permissions: Unify Location #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
33 tasks
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
4 times, most recently
from
aa054f0
to
78888b2
Compare
77 tasks
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
from
78888b2
to
06e5f89
Compare
32 tasks
anikiki
reviewed
Nov 6, 2024
app/src/androidTest/java/com/duckduckgo/app/location/GeoLocationPermissionsTestRequest.kt
Outdated
Show resolved
Hide resolved
anikiki
reviewed
Nov 6, 2024
...idTest/java/com/duckduckgo/app/location/data/LocationPermissionsRepositoryImplTestRequest.kt
Outdated
Show resolved
Hide resolved
anikiki
reviewed
Nov 6, 2024
app/src/main/java/com/duckduckgo/app/browser/BrowserChromeClient.kt
Outdated
Show resolved
Hide resolved
anikiki
reviewed
Nov 6, 2024
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Outdated
Show resolved
Hide resolved
anikiki
approved these changes
Nov 6, 2024
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
from
06e5f89
to
c628b45
Compare
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
from
c628b45
to
bac553f
Compare
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
from
52c8946
to
1f41356
Compare
21 tasks
nalcalag
requested changes
Nov 7, 2024
There was a problem hiding this comment.
@malmstein I tested your branch and there is a problem when the site requests more than one site permission.
You can reproduce it on https://webcammictest.com/ which would request mic and camera. I checked and it works fine in production.
The bug was introduced in branch feature/david/11-04-permissions_update_drm_dialogs
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
3 times, most recently
from
4931411
to
ae2a35b
Compare
anikiki
reviewed
Nov 8, 2024
app/src/main/java/com/duckduckgo/app/sitepermissions/SitePermissionsViewModel.kt
Show resolved
Hide resolved
anikiki
approved these changes
Nov 8, 2024
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
from
ae2a35b
to
b07c0b2
Compare
anikiki
approved these changes
Nov 12, 2024
malmstein
force-pushed
the
feature/david/10-28-permissions_unify_location
branch
from
d141612
to
98967c0
Compare
Task/Issue URL: https://app.asana.com/0/0/1208750400255371/f ### Description PIxels for the new site permission dialogs ### Steps to test this PR _Impression pixel_ - [x] open app visit permission.site - [x] tap on camera - [x] verify `m_site_permissions_dialog_impresssion` with parameter `type:camera` is sent - [x] tap on microphone - [x] verify `m_site_permissions_dialog_impresssion` with parameter `type: microphone ` is sent - [x] tap on camera + microphone - [x] verify `m_site_permissions_dialog_impresssion` with parameter `type:camera_and_microphone` is sent - [x] tap on drm - [x] verify `m_site_permissions_dialog_impresssion` with parameter `type: drm ` is sent - [x] tap on location - [x] verify `m_site_permissions_dialog_impresssion` with parameter `type:location` is sent _Click pixel_ - [x] open app visit permission.site - [x] tap on camera and enable system permission - [x] tap on Allow (checked box not pressed) - [x] verify `m_site_permissions_dialog_click` with parameters `type:camera` and `selection:allow_once` is sent - [x] tap on microphone and enable system permission - [x] tap on Deny (checked box not pressed) - [x] verify `m_site_permissions_dialog_click` with parameters `type:microphone` and `selection:deny_once` is sent - [x] tap on drm - [x] tap on Allow (checked box pressed) - [x] verify `m_site_permissions_dialog_click` with parameters `type:drm` and `selection:allow_always` is sent - [x] tap on location and enable system permissions - [x] tap on Deny (checked box pressed) - [x] verify `m_site_permissions_dialog_click` with parameters `type:location` and `selection:deny_always` is sent Notes: Pixels don’t include ATB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208719691317744/f
Description
This PR moves the Location permission logic to the SitePermissionsManager
Note: This
Steps to test this PR
Location permission granted
Location permission not granted
Location permission granted (not system granted)