Permissions: Update DRM, Camera and Microphone dialogs #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
33 tasks
malmstein
changed the title
malmstein
force-pushed
the
feature/david/10-30-permissions_update_location_dialogs
branch
from
0210977
to
f143ee3
Compare
malmstein
force-pushed
the
feature/david/11-04-permissions_update_drm_dialogs
branch
from
15a52bd
to
d0e96bd
Compare
32 tasks
malmstein
force-pushed
the
feature/david/10-30-permissions_update_location_dialogs
branch
from
f143ee3
to
f2e2692
Compare
malmstein
force-pushed
the
feature/david/11-04-permissions_update_drm_dialogs
branch
from
d0e96bd
to
8b35e56
Compare
anikiki
approved these changes
Nov 6, 2024
malmstein
force-pushed
the
feature/david/10-30-permissions_update_location_dialogs
branch
from
f2e2692
to
4164446
Compare
malmstein
force-pushed
the
feature/david/11-04-permissions_update_drm_dialogs
branch
from
8b35e56
to
2c9b9b1
Compare
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208578724221048 ### Description This PR updates the Site Permissions screens to match the Figma designs ### Steps to test this PR _Site Permissions_ - [x] Add permissions to a site (permissions.site) - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site and favicon are visible _Site Permissions Removed on Fire Button (Fireproof)_ - [x] Add location permissions to a site (permissions.site) - [x] Fireproof the site - [x] Ensure Fire Button will clear data on app restart - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site and favicon are visible - [x] Go back to the Browser and use the Fire Button - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site and favicon are visible _Site Permissions Removed on Fire Button_ - [x] Add location permissions to a site (permissions.site) - [x] Ensure Fire Button will clear data on app restart - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site and favicon are visible - [x] Go back to the Browser and use the Fire Button - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site is no longer visible _Individual Site Permissions_ - [x] Add location permissions to a site (permissions.site) - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site and favicon are visible - [x] Tap on the site to see the details page - [x] Verify location permission is allowed for the site _Disable overall location permission_ - [x] Add location permissions to a site (permissions.site) - [x] Open Settings -> Permissions -> Site Permissions - [x] Verify site and favicon are visible - [x] Toggle overall location permission off - [x] Verify site and favicon are visible - [x] Tap on the site to see the details page - [x] Verify “Disabled for all sites” visible next to Location - [x] Open a new tab and open permissions.site - [x] Tap on location, verify it’s red permission not given)
malmstein
merged commit 4594054
into
feature/david/10-30-permissions_update_location_dialogs
4 checks passed
malmstein
deleted the
feature/david/11-04-permissions_update_drm_dialogs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208578724221050/f
Description
Update Camera and Microphone dialogs to use a checkbox
It also updates the DRM dialog to match the other dialogs
Steps to test this PR
Camera - Allow Remember + System Permission Allowed
Camera - Allow + System Permission Allowed
Camera - Deny Remember
Camera - Deny
Microphone- Allow Remember + System Permission Denied
Microphone - Allow + System Permission Denied
Microphone - Deny Remember
Microphone - Deny
DRM - Allow Remember
DRM - Allow
DRM - Deny Remember
DRM - Deny