Permissions: Site Permissions screen #5238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @malmstein and the rest of your teammates on |
malmstein
force-pushed
the
feature/david/11-04-permissions_update_drm_dialogs
branch
from
d0e96bd
to
8b35e56
Compare
malmstein
force-pushed
the
feature/david/11-04-permissions_site_permissions_screen
branch
from
bdee2ec
to
3e52441
Compare
malmstein
force-pushed
the
feature/david/11-04-permissions_update_drm_dialogs
branch
from
8b35e56
to
2c9b9b1
Compare
malmstein
force-pushed
the
feature/david/11-04-permissions_site_permissions_screen
branch
from
3e52441
to
5684420
Compare
anikiki
reviewed
Nov 6, 2024
| class LaunchWebsiteAllowed(val domain: String) : Command() | ||
| } | ||
|
|
||
| init { | ||
| _viewState.value = ViewState( | ||
| askLocationEnabled = settingsDataStore.appLocationPermission, | ||
| // askLocationEnabled = settingsDataStore.appLocationPermission, |
There was a problem hiding this comment.
Note to remove commented out line.
anikiki
approved these changes
Nov 6, 2024
malmstein
merged commit 0110820
into
feature/david/11-04-permissions_update_drm_dialogs
6 of 7 checks passed
malmstein
deleted the
feature/david/11-04-permissions_site_permissions_screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1174433894299346/1208578724221048
Description
This PR updates the Site Permissions screens to match the Figma designs
Steps to test this PR
Site Permissions
Site Permissions Removed on Fire Button (Fireproof)
Site Permissions Removed on Fire Button
Individual Site Permissions
Disable overall location permission