Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: Migrate location permissions #5249

Conversation

malmstein
Copy link
Contributor

@malmstein malmstein commented Nov 6, 2024

Task/Issue URL: https://app.asana.com/0/1174433894299346/1208652517056709/f

Description

This PR adds a migration step for users that have currently stored location permissions for some sites.

Steps to test this PR

Migration with data

  • Install internal build from develop
  • Visit permission.site and add location permissions (set to Allow Always)
  • Install internal build from this branch
  • Open app and navigate to Setting / Permissions / Site Permissions
  • Verify permission.site is visible and set to Allo

Migration with data

  • Install internal build from develop
  • Visit permission.site and add location permissions (set to Deny Always)
  • Install internal build from this branch
  • Open app and navigate to Setting / Permissions / Site Permissions
  • Verify permission.site is visible and set to Deny

Migration location permissions

  • Install internal build from develop
  • Open app and navigate to Setting / Permissions / Site Permissions
  • Disable Location permission
  • Install internal build from this branch
  • Open app and navigate to Setting / Permissions / Site Permissions
  • Verify location permission is disabled

Migration not needed

  • Install internal build from develop
  • Visit permission.site and add location permissions (set to Allow Once)
  • Install internal build from this branch
  • Open app and navigate to Setting / Permissions / Site Permissions
  • Verify permission.site is not visible

Copy link
Contributor Author

malmstein commented Nov 6, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malmstein and the rest of your teammates on Graphite Graphite

@malmstein malmstein mentioned this pull request Nov 6, 2024
32 tasks
@malmstein malmstein marked this pull request as ready for review November 7, 2024 15:10
@anikiki anikiki self-assigned this Nov 7, 2024
@malmstein malmstein force-pushed the feature/david/10-28-permissions_unify_location branch from 1f41356 to ee6a71c Compare November 7, 2024 19:52
@malmstein malmstein force-pushed the feature/david/11-06-permissions_migrate_location_permissions branch from 548252c to 7c98804 Compare November 7, 2024 19:52
@malmstein malmstein merged commit eb39e7b into feature/david/10-28-permissions_unify_location Nov 7, 2024
4 of 5 checks passed
@malmstein malmstein deleted the feature/david/11-06-permissions_migrate_location_permissions branch November 7, 2024 20:00
@malmstein malmstein mentioned this pull request Nov 13, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants