Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions: Unify Location #5208

Merged
merged 8 commits into from
Nov 13, 2024
Merged

Permissions: Unify Location #5208

merged 8 commits into from
Nov 13, 2024
+1,006 −1,041

Commits on Nov 13, 2024

  1. Permissions: Unify Location

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    cd49a6f View commit details
    Browse the repository at this point in the history

  2. fix DRM title

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b6e3885 View commit details
    Browse the repository at this point in the history

  3. last changes to dialog copy

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3ee8584 View commit details
    Browse the repository at this point in the history

  4. make dialog scrollable

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c3c1cbb View commit details
    Browse the repository at this point in the history

  5. added message to the permissions dialog

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5c02314 View commit details
    Browse the repository at this point in the history

  6. fix test

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    98967c0 View commit details
    Browse the repository at this point in the history

  7. Site Permissions: Pixels (#5268) 

    Task/Issue URL: https://app.asana.com/0/0/1208750400255371/f

### Description
PIxels for the new site permission dialogs

### Steps to test this PR

_Impression pixel_
- [x] open app visit permission.site
- [x] tap on camera
- [x] verify `m_site_permissions_dialog_impresssion` with parameter
`type:camera` is sent
- [x] tap on microphone
- [x] verify `m_site_permissions_dialog_impresssion` with parameter
`type: microphone ` is sent
- [x] tap on camera + microphone
- [x] verify `m_site_permissions_dialog_impresssion` with parameter
`type:camera_and_microphone` is sent
- [x] tap on drm
- [x] verify `m_site_permissions_dialog_impresssion` with parameter
`type: drm ` is sent
- [x] tap on location
- [x] verify `m_site_permissions_dialog_impresssion` with parameter
`type:location` is sent

_Click pixel_
- [x] open app visit permission.site
- [x] tap on camera and enable system permission
- [x] tap on Allow (checked box not pressed)
- [x] verify `m_site_permissions_dialog_click` with parameters
`type:camera` and `selection:allow_once` is sent
- [x] tap on microphone and enable system permission
- [x] tap on Deny (checked box not pressed)
- [x] verify `m_site_permissions_dialog_click` with parameters
`type:microphone` and `selection:deny_once` is sent
- [x] tap on drm
- [x] tap on Allow (checked box pressed)
- [x] verify `m_site_permissions_dialog_click` with parameters
`type:drm` and `selection:allow_always` is sent
- [x] tap on location and enable system permissions
- [x] tap on Deny (checked box pressed)
- [x] verify `m_site_permissions_dialog_click` with parameters
`type:location` and `selection:deny_always` is sent

Notes: Pixels don’t include ATB
    @malmstein
    malmstein authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d1759eb View commit details
    Browse the repository at this point in the history

  8. ensure location permission is always stored

    @malmstein
    malmstein committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9256ce5 View commit details
    Browse the repository at this point in the history