Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpress packages to the latest version #78711

Merged
merged 75 commits into from
Jul 19, 2023

Conversation

noahtallen
Copy link
Contributor

@noahtallen noahtallen commented Jun 27, 2023

Proposed Changes

Now that #77046 has landed, we can update @wordpress packages to the latest version second latest version.

Note: even if an issue is marked as a resolved, new changes on trunk might still need to be migrated after a rebase.

Importantly, this does not really impact code running as a normal WordPress script. ETK, for example, uses the dependency extraction plugin, so it is already using the latest APIs provided via the Gutenberg plugin, not via Calypso's dependencies.

This does impact all code using @wordpress/ packages inside of the Calypso app and other Calypso bundles.

Testing Instructions

  1. Test primary local development work flows, like yarn and yarn start.
  2. Using calypso.live, test major features, like site creation, signup, the editor, etc.
  3. If you developed any feature using @wordpress/ packages, please test that feature!

Potential high impact areas:

  • Global styles. This had to be reworked somewhat.
  • WordPress components. The package has seen a lot of changes recently, so anywhere we use it could have a regression.

To do:

Complete:

  • Test it in the real world!
  • Fix remaining client type issues.
  • Fix all type errors in packages and ETK.
  • Fix type errors in packages blocking yarn install.
  • Remove unneeded type packages
  • Update resolutions field (I added a new script for doing this!)
  • Update all WP packages. (yarn up '@wordpress/*')
  • Update yarnrc.yml with peer dependency overrides.
  • Fix internal WP components type issue:
node_modules/@wordpress/components/build-types/autocomplete/types.d.ts(6,15): error TS2305: Module '"@wordpress/rich-text"' has no exported member 'RichTextValue'.
node_modules/@wordpress/components/build-types/dropdown-menu/types.d.ts(43,24): error TS2339: Property 'role' does not exist on type 'HTMLElement'.

This was caused by having custom type definitions in various packages overriding @wordpress/components types. These could be removed now that the package ships its own types.

@noahtallen noahtallen requested a review from a team June 27, 2023 22:01
@noahtallen noahtallen self-assigned this Jun 27, 2023
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 27, 2023
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

@matticbot
Copy link
Contributor

This PR modifies the release build for o2-blocks

To test your changes on WordPress.com, run install-plugin.sh o2-blocks update-wordpress-packages-latest on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

@noahtallen noahtallen force-pushed the update-wordpress-packages-latest branch from 0a489a7 to a5c7f66 Compare June 29, 2023 00:24
@matticbot
Copy link
Contributor

matticbot commented Jun 29, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1759 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-login                -4196 B  (-0.3%)    -2627 B  (-0.6%)
entry-subscriptions        -2972 B  (-0.2%)    -2031 B  (-0.5%)
entry-main                 -2294 B  (-0.1%)    -2109 B  (-0.4%)
entry-stepper              -1584 B  (-0.1%)    -2154 B  (-0.4%)
entry-browsehappy          -1195 B  (-1.0%)     -337 B  (-1.0%)
entry-domains-landing       -375 B  (-0.1%)     -145 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~77680 bytes added 📈 [gzipped])

name                                 parsed_size           gzip_size
import-flow                             +63042 B  (+2.0%)   +27063 B  (+3.1%)
pattern-assembler-step                  +62565 B  (+4.2%)   +26514 B  (+6.2%)
plugins                                  +2000 B  (+0.1%)     +280 B  (+0.1%)
gutenberg-editor                         -1969 B  (-0.4%)      -11 B  (-0.0%)
update-design-flow                       +1343 B  (+0.2%)     +848 B  (+0.4%)
people                                   -1306 B  (-0.2%)     -430 B  (-0.3%)
home                                     +1239 B  (+0.1%)     +444 B  (+0.1%)
site-setup-flow                          +1163 B  (+0.1%)      -13 B  (-0.0%)
hosting                                  +1036 B  (+0.2%)     -540 B  (-0.3%)
account                                   -983 B  (-0.1%)     -285 B  (-0.1%)
plans                                     -930 B  (-0.1%)    -1196 B  (-0.4%)
jetpack-connect                           +901 B  (+0.1%)      +35 B  (+0.0%)
videopress-flow                           +877 B  (+0.1%)     +695 B  (+0.2%)
site-purchases                            -831 B  (-0.1%)     -984 B  (-0.3%)
jetpack-cloud-plugin-management           +816 B  (+0.1%)     +452 B  (+0.2%)
purchases                                 -793 B  (-0.0%)     -952 B  (-0.2%)
media                                     -741 B  (-0.1%)     -376 B  (-0.1%)
marketplace                               -740 B  (-0.1%)    -1910 B  (-0.9%)
free-flow                                 +739 B  (+0.1%)     +468 B  (+0.2%)
link-in-bio-tld-flow                      +703 B  (+0.1%)     +345 B  (+0.1%)
settings                                  -690 B  (-0.1%)    -1606 B  (-0.8%)
tailored-ecommerce-flow                   +679 B  (+0.1%)     +807 B  (+0.6%)
copy-site-flow                            +679 B  (+0.1%)     +818 B  (+0.6%)
jetpack-cloud-agency-dashboard            +629 B  (+0.1%)     +134 B  (+0.1%)
domains                                   -619 B  (-0.0%)    -1192 B  (-0.3%)
sites-dashboard                           +617 B  (+0.2%)     +812 B  (+0.8%)
sensei-flow                               +592 B  (+0.2%)     +814 B  (+0.7%)
import-hosted-site-flow                   +558 B  (+0.0%)     +614 B  (+0.1%)
posts-custom                              -554 B  (-0.1%)     -186 B  (-0.1%)
posts                                     -554 B  (-0.1%)     -186 B  (-0.1%)
accept-invite                             +533 B  (+0.1%)      -20 B  (-0.0%)
signup                                    +529 B  (+0.2%)      -15 B  (-0.0%)
site-blocks                               -513 B  (-0.1%)     -189 B  (-0.1%)
me                                        -513 B  (-0.1%)     -189 B  (-0.1%)
account-close                             -513 B  (-0.1%)     -189 B  (-0.1%)
security                                  -506 B  (-0.1%)     -198 B  (-0.1%)
help                                      -506 B  (-0.1%)     -199 B  (-0.1%)
notification-settings                     -504 B  (-0.1%)     -197 B  (-0.1%)
podcasts-flow                             +490 B  (+0.2%)     +783 B  (+0.9%)
privacy                                   -485 B  (-0.1%)     -183 B  (-0.1%)
promote-post                              -481 B  (-0.1%)     -130 B  (-0.1%)
subscribers                               +432 B  (+0.1%)     +509 B  (+0.5%)
jetpack-cloud-agency-signup               +418 B  (+0.8%)     +140 B  (+0.7%)
checkout                                  -411 B  (-0.0%)     +550 B  (+0.1%)
jetpack-cloud-partner-portal              -402 B  (-0.1%)     -178 B  (-0.1%)
write-flow                                +397 B  (+0.0%)      -67 B  (-0.0%)
build-flow                                +397 B  (+0.0%)      -68 B  (-0.0%)
add-ons                                   -340 B  (-0.1%)     -127 B  (-0.2%)
devdocs                                   +331 B  (+0.2%)      +19 B  (+0.0%)
start-writing-flow                        +311 B  (+1.0%)      +59 B  (+0.6%)
design-first-flow                         +311 B  (+1.0%)      +66 B  (+0.7%)
email                                     +292 B  (+0.0%)      -32 B  (-0.0%)
trial-wooexpress-flow                     +273 B  (+0.3%)      +32 B  (+0.1%)
newsletter-post-setup-flow                +236 B  (+0.2%)      +31 B  (+0.1%)
link-in-bio-post-setup-flow               +236 B  (+0.2%)      +27 B  (+0.1%)
free-post-setup-flow                      +236 B  (+0.2%)      +33 B  (+0.1%)
theme                                     -170 B  (-0.0%)    -1221 B  (-0.7%)
woocommerce-installation                  -110 B  (-0.0%)      -56 B  (-0.1%)
newsletter-flow                           +108 B  (+0.9%)      +30 B  (+0.8%)
new-hosted-site-flow                      +108 B  (+0.8%)      +30 B  (+0.9%)
link-in-bio-flow                          +108 B  (+1.0%)      +29 B  (+0.9%)
settings-writing                           -89 B  (-0.0%)     -278 B  (-0.2%)
settings-security                          -89 B  (-0.0%)      -87 B  (-0.1%)
settings-discussion                        -89 B  (-0.0%)      -87 B  (-0.1%)
with-theme-assembler-flow                  +86 B  (+0.1%)      +13 B  (+0.1%)
plugin-bundle-flow                         -76 B  (-0.0%)     +508 B  (+1.0%)
earn                                       -76 B  (-0.0%)      -89 B  (-0.1%)
site-logs                                  +69 B  (+0.0%)      -24 B  (-0.0%)
pages                                      -69 B  (-0.0%)      -36 B  (-0.0%)
woocommerce                                -68 B  (-0.0%)      -50 B  (-0.1%)
preview                                    -68 B  (-0.0%)      -48 B  (-0.1%)
jetpack-social                             -68 B  (-0.0%)      -50 B  (-0.1%)
jetpack-search                             -68 B  (-0.0%)      -50 B  (-0.0%)
jetpack-cloud                              -68 B  (-0.0%)      -50 B  (-0.1%)
import                                     -68 B  (-0.0%)      -50 B  (-0.1%)
google-my-business                         -68 B  (-0.0%)      -50 B  (-0.0%)
export                                     -68 B  (-0.0%)      -50 B  (-0.1%)
customize                                  -68 B  (-0.0%)      -50 B  (-0.1%)
concierge                                  -68 B  (-0.0%)      -50 B  (-0.0%)
comments                                   -68 B  (-0.0%)      -50 B  (-0.0%)
settings-jetpack                           -67 B  (-0.0%)      -49 B  (-0.0%)
migrate                                    -67 B  (-0.0%)      -47 B  (-0.1%)
jetpack-cloud-settings                     -63 B  (-0.0%)      -84 B  (-0.1%)
settings-reading                           -52 B  (-0.0%)      -88 B  (-0.1%)
jetpack-cloud-pricing                      -48 B  (-0.0%)     -100 B  (-0.1%)
automated-transfer-state-middleware        -42 B  (-0.2%)      -22 B  (-0.2%)
marketing                                  -40 B  (-0.0%)      -76 B  (-0.0%)
jetpack-cloud-features-comparison          -40 B  (-0.0%)      -41 B  (-0.0%)
scan                                       -35 B  (-0.0%)      -48 B  (-0.0%)
reader                                     +33 B  (+0.0%)     +283 B  (+0.1%)
settings-performance                       -28 B  (-0.0%)      -70 B  (-0.0%)
activity                                   -19 B  (-0.0%)      -62 B  (-0.0%)
transferring-hosted-site-flow              +13 B  (+0.0%)       -1 B  (-0.0%)
backup                                     -11 B  (-0.0%)      -40 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~16473 bytes added 📈 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-automattic-global-styles-src-components-global-styles-variations     +62763 B  (+4.8%)   +26498 B  (+7.1%)
async-load-automattic-design-preview                                            +62021 B  (+4.6%)   +25831 B  (+6.7%)
async-load-design-wordpress-components-gallery                                   -3707 B  (-0.7%)     -141 B  (-0.1%)
async-load-calypso-lib-account-settings-helper                                    -728 B  (-0.4%)     -154 B  (-0.3%)
async-load-calypso-post-editor-editor-media-modal                                 -673 B  (-0.1%)     -386 B  (-0.1%)
async-load-signup-steps-woocommerce-install-step-business-info                    -669 B  (-1.0%)      -96 B  (-0.5%)
async-load-quick-language-switcher                                                -664 B  (-0.9%)     -140 B  (-0.6%)
async-load-automattic-help-center                                                 -579 B  (-0.1%)     -102 B  (-0.1%)
async-load-calypso-components-web-preview-component                               -474 B  (-0.1%)     -150 B  (-0.1%)
async-load-calypso-blocks-jitm-templates-modal                                    +469 B  (+5.9%)     +156 B  (+5.3%)
async-load-calypso-post-editor-media-modal                                        -467 B  (-0.0%)      -78 B  (-0.0%)
async-load-calypso-layout-masterbar-checkout-tsx                                  +439 B  (+0.3%)     +331 B  (+0.8%)
async-load-design-playground                                                      -437 B  (-0.0%)     -104 B  (-0.0%)
async-load-signup-steps-domains                                                   +419 B  (+0.1%)     +778 B  (+0.7%)
async-load-signup-steps-theme-selection                                           +416 B  (+0.3%)     +912 B  (+2.0%)
async-load-masterbar-help-center                                                  -415 B  (-1.4%)     -113 B  (-1.2%)
async-load-calypso-layout-masterbar-checkout                                      -415 B  (-0.5%)      -77 B  (-0.3%)
async-load-signup-steps-woocommerce-install-step-store-address                    +399 B  (+0.6%)     +188 B  (+0.9%)
async-load-calypso-my-sites-stats-stats-purchase                                  -270 B  (-0.5%)      -81 B  (-0.5%)
async-load-signup-steps-add-ons                                                   -259 B  (-0.5%)      -76 B  (-0.4%)
async-load-design                                                                 +215 B  (+0.0%)     +439 B  (+0.1%)
async-load-calypso-blocks-jitm                                                    +202 B  (+2.1%)      +40 B  (+1.2%)
async-load-calypso-my-sites-checkout-modal                                        +176 B  (+0.0%)      +44 B  (+0.0%)
async-load-calypso-layout-guided-tours-component                                   -77 B  (-0.1%)      -41 B  (-0.2%)
async-load-calypso-blocks-support-article-dialog                                   -77 B  (-2.3%)      -50 B  (-3.8%)
async-load-design-blocks                                                           -69 B  (-0.0%)    +1101 B  (+0.2%)
async-load-calypso-my-sites-stats-stats-insights                                   +38 B  (+0.1%)      +28 B  (+0.1%)
async-load-calypso-blocks-support-article-dialog-dialog                            +32 B  (+0.0%)      +25 B  (+0.0%)
async-load-signup-steps-woocommerce-install-confirm                                -29 B  (-0.1%)       -5 B  (-0.0%)
async-load-signup-steps-difm-site-picker                                           +28 B  (+0.0%)       -2 B  (-0.0%)
async-load-signup-steps-design-picker                                              +26 B  (+0.0%)       +5 B  (+0.0%)
async-load-signup-steps-site-picker                                                +22 B  (+0.0%)       -7 B  (-0.0%)
async-load-calypso-blocks-editor-checkout-modal                                    -20 B  (-0.0%)       -5 B  (-0.0%)
async-load-signup-steps-p2-join-workspace                                          +19 B  (+0.1%)       +3 B  (+0.0%)
async-load-signup-steps-user                                                       +18 B  (+0.0%)       +2 B  (+0.0%)
async-load-calypso-blocks-login-lost-password-form                                 -18 B  (-0.1%)       -5 B  (-0.1%)
async-load-signup-steps-p2-confirm-email                                           +16 B  (+0.1%)       +4 B  (+0.0%)
async-load-signup-steps-p2-complete-profile                                        +16 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-p2-get-started                                             +15 B  (+0.1%)       +5 B  (+0.1%)
async-load-signup-steps-p2-site                                                    +14 B  (+0.0%)       +2 B  (+0.0%)
async-load-signup-steps-p2-details                                                 +14 B  (+0.1%)       +4 B  (+0.1%)
async-load-signup-steps-woocommerce-install-transfer                               +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-woocommerce-install                                        +13 B  (+0.4%)       +3 B  (+0.3%)
async-load-signup-steps-website-content                                            +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-test-step                                                  +13 B  (+0.1%)       +1 B  (+0.0%)
async-load-signup-steps-store-features                                             +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-starting-point                                             +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-social-profiles                                            +13 B  (+0.1%)       +1 B  (+0.0%)
async-load-signup-steps-site-or-domain                                             +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-site-options                                               +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-site                                                       +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-rewind-were-backing                                        +13 B  (+0.1%)       +1 B  (+0.0%)
async-load-signup-steps-rewind-migrate                                             +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-rewind-form-creds                                          +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-reader-landing                                             +13 B  (+0.1%)       +1 B  (+0.0%)
async-load-signup-steps-plans-theme-preselected                                    +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-plans-atomic-store                                         +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-plans                                                      +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-page-picker                                                +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-new-or-existing-site                                       +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-intent                                                     +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-emails                                                     +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-creds-permission                                           +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-creds-confirm                                              +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-creds-complete                                             +13 B  (+0.1%)       +1 B  (+0.0%)
async-load-signup-steps-courses                                                    +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-clone-start                                                +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-clone-ready                                                +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-clone-point                                                +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-clone-jetpack                                              +13 B  (+0.1%)       +1 B  (+0.0%)
async-load-signup-steps-clone-destination                                          +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-clone-credentials                                          +13 B  (+0.0%)       +1 B  (+0.0%)
async-load-signup-steps-clone-cloning                                              +13 B  (+0.1%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@noahtallen
Copy link
Contributor Author

Progress for the day:

  • All type errors in packages are resolved now! This means we can use yarn install.
  • All type errors in ETK are resolved.
  • I merged in the fix for global styles, so we can actually build the app now :)
  • Made good progress on various client type errors, especially the button variant and ExternalLink issues.

Up next, there are about 50 remaining type errors under client, and we'll need to tackle the unit test failures and e2e test suite issue.

Beyond that, the jest update will hopefully resolve the issue with ETK tests, as well as the remaining peer dependency warning.

@tyxla
Copy link
Member

tyxla commented Jul 7, 2023

For the protocol, I'm holding off reviewing this one and iterating on it while we're working on some of its requirements (like #78786 and its own dependency #79097)

@noahtallen noahtallen force-pushed the update-wordpress-packages-latest branch from cf4680a to f8127d8 Compare July 8, 2023 01:19
@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update-wordpress-packages-latest on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

@noahtallen
Copy link
Contributor Author

For the protocol, I'm holding off reviewing this one and iterating on it while we're working on some of its requirements (like #78786 and its own dependency #79097)

@tyxla I just rebased on trunk after merging #79097. I think the Jest PR should no longer be a blocker, since we no longer have a dependency on @wordpress/scripts. (this means we don't have a peer dependency conflict any more.)

I also fixed up some more type issues that got introduced on trunk which brings us to a nice milestone! yarn install completes with no warnings or errors :D

@tyxla
Copy link
Member

tyxla commented Jul 10, 2023

For the protocol, I'm holding off reviewing this one and iterating on it while we're working on some of its requirements (like #78786 and its own dependency #79097)

@tyxla I just rebased on trunk after merging #79097. I think the Jest PR should no longer be a blocker, since we no longer have a dependency on @wordpress/scripts. (this means we don't have a peer dependency conflict any more.)

I also fixed up some more type issues that got introduced on trunk which brings us to a nice milestone! yarn install completes with no warnings or errors :D

This is amazing, thank you @noahtallen 🙌

I'm hoping to be able to help with the failures throughout the week.

@noahtallen noahtallen force-pushed the update-wordpress-packages-latest branch from 0863ece to af5974f Compare July 10, 2023 21:02
@noahtallen
Copy link
Contributor Author

I just worked through type issues after rebasing again. I think we should be down to only around 15 or so!

@tyxla tyxla force-pushed the update-wordpress-packages-latest branch 2 times, most recently from f626da7 to a33705c Compare July 11, 2023 12:58
@noahtallen noahtallen force-pushed the update-wordpress-packages-latest branch from 063e890 to a5014ec Compare July 19, 2023 20:15
@noahtallen noahtallen merged commit d3c9b16 into trunk Jul 19, 2023
@noahtallen noahtallen deleted the update-wordpress-packages-latest branch July 19, 2023 21:17
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 19, 2023
@a8ci18n
Copy link

a8ci18n commented Jul 19, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8600733

Hi @noahtallen, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Disable email notifications
  • Disable mobile notifications
  • Enable mobile notifications
  • Disable SMS notifications
  • Enable SMS notifications

Thank you in advance!

timur987 pushed a commit that referenced this pull request Jul 20, 2023
* Add script which updates package.json resolutions field

* Update @WordPress packages to latest versions in package.json resolutions

* Update all @WordPress packages to the latest version

* Update internal @wordpress/data peer dependency versions

* Resolve most peer dependency issues

* Use ComponentProps for some WP component type imports

* Rework submenu popover to remove legacy offset props

* Fix all Button variant type issues

* Remove uneeded button wrapper component in info-tooltip

* Fix type for close modal event in page pattern modal

* Add ts expect error for ExternalLink required children prop

* Add onChange type definition for CustomSelectControl for language-picker

* Remove unused @types/wordpress__ packages

* Remove uneeded entries in yarnrc.yml

* Change another case of isPrimary to variant

* Fix global styles package for new WordPress package versions (#78715)

* @automattic/global-styles: Replace @wordpress/edit-site apis with new ones

* Use fixed version of private-apis package to make __private symbol consistent

* Use ExperimentalBlockEditorProvider to initialize Iframe

* Fix unable to get fontFamilies

* Fix styles

* Fix style variation preview

* Fix types

* Replace mergeWith with deepmerge

* Get rid of isEmpty and mapValues in global-stypes pkg

* Add comments

* Revert some changes

* cleanEmptyObject: Fix type

* transformStyles: Fix type

* WP components: Fix types

* Move EditorStyles into the children of the Iframe

---------

Co-authored-by: arthur <[email protected]>

* Delete several @WordPress module declarations that duplicate bundled types

* Remove uneeded HTMLElement override

* Remove Global Styles wp components type declaration override

* Remove manage purchases renew toggle wp components type override

* Add back html element hotfix

* Remove imports of deleted type patch files

* Fix type errors related to re-declaring Button prop types

* Fix type errors related to ExternalLink requiring children

* Fix type errors related to Modal isOpen prop

* Remove registerPlugin override

* Remove target blank from ExternalLink, because it isn't used by the component internally

* Fix several prop issues related to ExternalLink (remove target, include children)

* Add missing @types/wordpress__block-library package

* Fix type errors related to Modal open prop

* Remove size prop in a couple cases because it doesn't do anything

* Fix type errors related to importing component prop types

* Fix useState types for date time picker example

* yarn dedupe

* Fix type issue with NavigatorButton wrapper class name

* Remove another wp components type override file

* Update onNavigatorPathChange argument which is sometimes undefined

* Fix a type issue with global styles context

* Fix eslint issues with hooks in modified files

* Remove unused translate import

* Fix type issue where reader button couldn't be disabled

* Remove disabled from a Button instance which is a link

* Fix state type related to FontSizePicker

* Fix odd issue with query control types

* Fix issue with SlotFill not being typed

* Remove broken types from ToolbarGroup as it's just an example

* Fix issue with arr.includes undefined

* Fix issue with combobox onchange arg type

* Remove disabled from another button link

* Cast translateresult to string for input to label

* Cast string to more specific type for log tab

* Fix onChange type for another combobox

* Add missing onhover prop to component

* Fix issue with Token value types

* Add missing labels to notification toggles

* Remove useless wrapper component

* Add types to callback args

* Remove uneeded ts expect err and update component props for combobox control

* fix color type definition for global styles

* Remove uneeded types in callback

* Remove useless component wrapper

* Utilize useLocalizeUrl() where necessary

* Fix some test snapshots

* Fix composite checkout tests by introducing field reset

* dedupe

* Fix most of the remaining TS errors

* Remove uneeded wrapper components

* Add expect-error to incorrect .then error

* Assembler: Fix the main layout is broken (#79275)

* Comment out wrapperClassName which causes a type error

* Change a few HStack props from alignItems to alignment

* Assembler: Fix the styles of the navigator button (#79338)

* Lock file update

* Make Button variants more consistent with trunk

* Use better approach for picking anchor button types

---------

Co-authored-by: arthur <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
@alshakero
Copy link
Member

alshakero commented Jul 21, 2023

Just noting that this changed the colors of primary buttons that use @wordpress/components. Because core has a new color palette now.

p1689919222911329-slack-C05CT832K2T

@yashwin
Copy link
Contributor

yashwin commented Jul 24, 2023

@noahtallen: I see a label prop has been added to some ToggleControl components and this has caused some issues in the Jetpack Pro Dashboard.

Screenshot 2023-07-24 at 11 29 39 AM

Update

Fixed it here - #79777

timur987 added a commit that referenced this pull request Jul 24, 2023
* Change skeleton animation to comply with dotcom

* Plugins: Put category and search result breadcrumb always on the 2nd level (#79483)

* Plugins: Put category and search result breadcrumb always on the second-level

* Remove logic for reset breadcrumbs on categories pages as it will always be reset

* Add-Ons: Hide Jetpack AI add-on card for sites that already support the feature (#79495)

* Use the site active features to decide if the add-on should be showed

* Use a constant instead of the literal feature name

* Move feature flag to staging level, so we can test it easily

* Remove fixed width on button (#79534)

* Domains: Fix second-level domains in some domain availability error notices (#79200)

* Fix second-level domains in some domain availability notices

* Add missing parameter in `getAvailabilityNotice` call

* Remove unnecessary code

* Anchor.fm: Fix css rules that break after removing Anchor from stepper (#79295)

* add className to SetupForm

* add placeholder text color

---------

Co-authored-by: Andrés Blanco <[email protected]>

* Move AI Assistant add-on card to production (#79486)

* Domain transfer: Clear store in complete step (#79538)

* Added focus outline to ellipsis menu in Subscribers page (#79479)

* Adding FAQs to domain transfer page (#79503)

* Adding FAQs to domain transfer page

* Updated tracks names

* Update to dns answer

* Updated transfer time answer

* Updates to styles based on @nuriapenya's feedback

* chore: update entry for simpleSiteFreePlanUser. (#79519)

* Update entry for simpleSiteFreePlanUser.

* Use correct encryption key

* Revert "chore: update entry for simpleSiteFreePlanUser. (#79519)" (#79542)

This reverts commit 7f5bc4c.

* Signup: Remove type casting for domainCartItem in useRecordSignupComplete (#79547)

* Jetpack Agency Dashboard - Presales Chat: modify/ignore chat staffing check (#79475)

* Jetpack Agency Dashboard - Presales Chat modify/ignore chat staffing check

* don't use the useMessagingAvailability hook unecessarily

* remove inline comment

* Upadte/domain transfer faqs (#79545)

* Add additional question around being charged

* Made name servers plural and added context around additional services

* Adjusted font-size based on feedback

* Domain Transfer: FAQ: Address free transfer offer

---------

Co-authored-by: Eric Binnion <[email protected]>

* chore: update entry for simpleSiteFreePlanUser, take 2. (#79550)

* Update entry for simpleSiteFreePlanUser.

* Use correct encryption key

* Update the store sandbox value.

* Congrats: Fix expiry date data for plans (#79518)

* Domain Transfers: fixes spacing for FAQ section. (#79555)

* Domain Transfers: fixes spacing for FAQ section.

* Domain Transfers: fixes spacing for FAQ section.

---------

Co-authored-by: cpap <[email protected]>

* Domain Transfer: Hide FAQ section for non-en locales (#79559)

* remove negative margin on large width (#79543)

* Remove plans URL parameter from eCommerce trial nudge in settings page (#79541)

* Add customised prompts for each section (#79536)

QoL changes

* Domain Transfer: FAQ: Correct punctuation (#79566)

* Fix small error in input chrono example (#79522)

* Reader: remove isDiscover prop where no longer needed (#79505)

* Domain Transfer: Hide FAQ by feature flag (#79579)

* Stats: Adding support for more currencies (#79517)

Co-authored-by: Jason Moon <[email protected]>

* Plans 2023: Update ecommerce and business storage labels (#79458)

* Change storage feature from 200GB to 50GB

* Add feature flag

* Account for legacy storage on /plans

* Disable Sentry and JS error reporting in calypso.live (#79582)

* Do not permanently enable Sentry in wpcalypso env
* Add config flag to force enable sentry if needed
* Disable catch-js-errors for wpcalypso

* Add feature flag to hide Woo extensions section (#79583)

* Import: add migration starting point event to migration flow (#79415)

* Adding migration starting point events to migration flow

* Adding a dictionary variable for flow mapping

* Jetpack Pro Dashboard: restrict users to add only one phone number to downtime monitoring (#79513)

* Add migration trial feature flag (#79593)

* In Help Center E2E, search "posts", not "domains" (#79580)

We are currently dodging a bug (79576) with a broken article.

* Assembler CTA: Fix selecting the CTA doesn't go to the editor on mobile (#79591)

* Design Picker: Fix selecting Assembler CTA doesn't go to the editor on mobile

* Fix types

* Fix variable name

* client/landing/stepper/declarative-flow/internals/steps-repository/domain-transfer-complete/complete-domains-transferred.tsx (#79592)

- add missing full stop at end of sentence.

* Reader: Properly handle thumbnail fetch errors (#79417)

* Reader: Properly handle thumbnail fetch errors

* Move catch at the end

* Reader: Fix post card with missing comments (#79597)

* Add reader sub-section to performance tracking (#79537)

* Replaces 'missing payment method' message for in-app purchases. (#79549)

* Replaces 'missing payment method' message for in-app purchases with 'In-App Purchase'.

* Adds test cases for change.

* Tighten up PremiumBadge display for fonts & colours (#79487)

If the PremiumBadge tooltip is not being used and the content of the
badge has overflowed and when using the animated compact mode
then overflow the tooltip into the tooltip rather than it being trimmed
behind an ellipses.


Secondly don't wrap the custom fonts / custom colours heading text,
prefer to force more of the adjacent PremiumBadge to overflow instead.

* Fix Jetpack Starter Upgrade button in /me/purchases page. (#79507)

* enable logged out discover page (#79558)

* enable logged out

* handle logged out recommended stream

* remove unnecessary tags handling in streams

* add masterbar item

* add reader header section

* initial commit (#78958)

Co-authored-by: Andrés Blanco <[email protected]>

* Odysseus: Change endpoint to hit newer /odie (#79587)

* Badge: Update references to point to new package component (#78812)

* Fix typescript errors with badge type

* Update BadgeProps to break out BadgeType props list

* Move Badge component to @automattic/components

* Update references to point to new package component

* Ignore eslint warnings or the purposes of this PR

* update playground scope

* Fix ref

* Remove unused badge files (#78814)

* Remove isREquired since we're setting a default.

* Update TSX rather than JSX

* Don't delete anything yet.

* Restore deleted files for now

* Fix type errors

* Update branch with BadgeType rather than all BadgeProps

* Remove deleted files

* One more :)

* Remove dupe reference

* Remove duplicate in devdocs playground

* Update the paid media flow to match the GF spec. (#79521)

* Deprecate the copied version of the old plans grid.

* Update `onboarding-pm` flow to match the required spec.

- Use the new pricing grid
- Enable the free plan + paid domain model
- Show the 1y/2y toggle

* Change user step form title on onboarding pm flow

* Fix glitch when going back from plans to domains

* Remove `isOnboardingPMFlow` call, since it's for checking a different
Stepper flow.

---------

Co-authored-by: Dehan <[email protected]>

* My Sites: Clear site on /domains/manage (#79609)

* Odysseus: Rename everything to Odie  (#79588)

* Odysseus rename to odie: Global search/replaces

* New paths

* Move assets

---------

Co-authored-by: Daniel López <[email protected]>

* Rollback design of bundle cards on pricing page (#79490)

* move discover nav higher in componentry (#79608)

* enable logged out

* handle logged out recommended stream

* remove unnecessary tags handling in streams

* add masterbar item

* add reader header section

* move nav higher in heirarchy

* use withDimensions to compare to reader two column cutoff

* comment css

* remove margin on single column

* Send API error status as tracks error message to fix error of sending react jsx (#79575)

* Google Ads: Add delay to conversion event to avoid request cancellation (#79500)

After the recordPurchase analytics method is called, there is a page redirect. This will cancel the google analytics conversion event because the redirect happens so quickly. We add a delay to provide time for the gtag event to resolve.

* Plans 2023: Enable updated storage labels in production (#79584)

* Domains transfer flow: improve copy and design details. (#79618)

* Domains transfer flow: improve copy and design details.

* refactor navigation component (#79620)

* Launchpad: Wider layout for cards on the right (#79444)

* wider layout for cards on the right

* column gap to 32px and removes cards padding on >1040

* remove padding after break-small

* adding padding after break-mobile

---------

Co-authored-by: Andrés Blanco <[email protected]>

* Paid Stats: Add paid plan purchase success banner (#79585)

Co-authored-by: Dognose <[email protected]>

* Launchpad: Track views as a side effect rather than on every render (#79573)

* Track views as a side effect rather than on every rerender

* Also fix write checklist

* Move tracks view event into the parent component

* Clean up the feature flag usage since the change is in production already (#79557)

* Domain Transfer: Remove progress bar (#79629)

* Domain Transfer: Remove progress bar

* Domain Transfer: hide progress bar for complete step

* Happy Blocks: Update Happy Blocks copy (#79615)

* [Odie] Experiment preparations bottom interaction (#79624)

* Simple animation (no Wapuu)

* Missed staged change...

* From bottom to top animation

* Fix wapuu style

* New hosted site flow: add FAQ below plans grid (#79574)

* New hosted site flow: add plans FAQ below plans grid

* Make titanMonthlyRenewalCost prop optional

* Squeeze FAQ accordion

* include latest in stream key tag handling (#79628)

* Domain Transfer: Screen 2 fixes/changes (#79607)

* Fix domains step title copy

* Only show total if at least one domain is valid

* Fix button size on desktop

* Don't show refresh if not actionable

* Disable remove on initial state

* Remove icon

* Add hover states

* Use scss variable

* Increase button size

* Hide dns check box

* Change add another domain copy

* Change refresh icon

* Domain Transfer: Step 2: Update subheader copy to be smoother

---------

Co-authored-by: Eric Binnion <[email protected]>

* dont show tag sidebar if not a tag page (#79626)

* Help center e2e: wait for search-specific request (#79637)

* Update wordpress packages to a recent version (#78711)

* Add script which updates package.json resolutions field

* Update @WordPress packages to latest versions in package.json resolutions

* Update all @WordPress packages to the latest version

* Update internal @wordpress/data peer dependency versions

* Resolve most peer dependency issues

* Use ComponentProps for some WP component type imports

* Rework submenu popover to remove legacy offset props

* Fix all Button variant type issues

* Remove uneeded button wrapper component in info-tooltip

* Fix type for close modal event in page pattern modal

* Add ts expect error for ExternalLink required children prop

* Add onChange type definition for CustomSelectControl for language-picker

* Remove unused @types/wordpress__ packages

* Remove uneeded entries in yarnrc.yml

* Change another case of isPrimary to variant

* Fix global styles package for new WordPress package versions (#78715)

* @automattic/global-styles: Replace @wordpress/edit-site apis with new ones

* Use fixed version of private-apis package to make __private symbol consistent

* Use ExperimentalBlockEditorProvider to initialize Iframe

* Fix unable to get fontFamilies

* Fix styles

* Fix style variation preview

* Fix types

* Replace mergeWith with deepmerge

* Get rid of isEmpty and mapValues in global-stypes pkg

* Add comments

* Revert some changes

* cleanEmptyObject: Fix type

* transformStyles: Fix type

* WP components: Fix types

* Move EditorStyles into the children of the Iframe

---------

Co-authored-by: arthur <[email protected]>

* Delete several @WordPress module declarations that duplicate bundled types

* Remove uneeded HTMLElement override

* Remove Global Styles wp components type declaration override

* Remove manage purchases renew toggle wp components type override

* Add back html element hotfix

* Remove imports of deleted type patch files

* Fix type errors related to re-declaring Button prop types

* Fix type errors related to ExternalLink requiring children

* Fix type errors related to Modal isOpen prop

* Remove registerPlugin override

* Remove target blank from ExternalLink, because it isn't used by the component internally

* Fix several prop issues related to ExternalLink (remove target, include children)

* Add missing @types/wordpress__block-library package

* Fix type errors related to Modal open prop

* Remove size prop in a couple cases because it doesn't do anything

* Fix type errors related to importing component prop types

* Fix useState types for date time picker example

* yarn dedupe

* Fix type issue with NavigatorButton wrapper class name

* Remove another wp components type override file

* Update onNavigatorPathChange argument which is sometimes undefined

* Fix a type issue with global styles context

* Fix eslint issues with hooks in modified files

* Remove unused translate import

* Fix type issue where reader button couldn't be disabled

* Remove disabled from a Button instance which is a link

* Fix state type related to FontSizePicker

* Fix odd issue with query control types

* Fix issue with SlotFill not being typed

* Remove broken types from ToolbarGroup as it's just an example

* Fix issue with arr.includes undefined

* Fix issue with combobox onchange arg type

* Remove disabled from another button link

* Cast translateresult to string for input to label

* Cast string to more specific type for log tab

* Fix onChange type for another combobox

* Add missing onhover prop to component

* Fix issue with Token value types

* Add missing labels to notification toggles

* Remove useless wrapper component

* Add types to callback args

* Remove uneeded ts expect err and update component props for combobox control

* fix color type definition for global styles

* Remove uneeded types in callback

* Remove useless component wrapper

* Utilize useLocalizeUrl() where necessary

* Fix some test snapshots

* Fix composite checkout tests by introducing field reset

* dedupe

* Fix most of the remaining TS errors

* Remove uneeded wrapper components

* Add expect-error to incorrect .then error

* Assembler: Fix the main layout is broken (#79275)

* Comment out wrapperClassName which causes a type error

* Change a few HStack props from alignItems to alignment

* Assembler: Fix the styles of the navigator button (#79338)

* Lock file update

* Make Button variants more consistent with trunk

* Use better approach for picking anchor button types

---------

Co-authored-by: arthur <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>

* Fix bug where first input to signup form would get cleared (#79643)

* Domain Transfer: Remove customer margin-bottom on label (#79642)

* Domain Transfer: Remove customer margin-bottom on label

* Domain Transfer: Address label margin-bottom for mobile as well

* Payment Methods: Fix payment method styling when changing methods (#79581)

* Update styles for ExistingCardLabel

* Remove label component wrapping

---------

Co-authored-by: Chris Diehl <[email protected]>

* Paid Stats: Add display logic for free and paid purchase success notices (#79590)

Co-authored-by: Jason Moon <[email protected]>

* Domains Transfers: Fix align for labels (#79645)

* Use optional chaining to fix SPT store close issue (#79653)

* Domains Transfers: Move the total price to the Transfer button (#79650)

* Domains Transfers: Move the total price to the Transfer button

* Show  when no valid domain

* Domain Transfer: Remove unused CSS

* Domain Transfer: Breaking out translations for CTA to minimize sprintf unless necessary.

---------

Co-authored-by: Eric Binnion <[email protected]>

* Plans 2023: Check if Ecommerce is current plan for legacy storage label (#79657)

* Domain Transfer: Dedupe logic for total price (#79659)

* Domains Transfers: Move trash/refresh to the validation text (#79649)

* Domains Transfers: Move trash/refresh to the validation text

* Domain Transfer: remove domain control CSS

* Domain Transfer: Tweaks to field validation positioning

---------

Co-authored-by: Eric Binnion <[email protected]>

* Revert "Domains Transfers: Move trash/refresh to the validation text (#79649)" (#79660)

This reverts commit 7689f2b.

* remove purchase page feature gating (#79661)

* Reading settings: correctly update incoming fields based on prevState to avoid race condition (#79509)

* Add themes Bute and Entry to the theme preview color block list (#79667)

* After switching theme, fetch latest site front page options (#79544)

* Register PLAN_MIGRATION_TRIAL constants (#79313)

* Domains Transfers: Move trash/refresh to the validation text (#79665)

* Domains Transfers: Move trash/refresh to the validation text

* Domain Transfer: remove domain control CSS

* Domain Transfer: Tweaks to field validation positioning

* Domain Transfer: Address discard domain when no validation

* Domain Transfer: Move to FormInputValidation over FormExplanation to minimize reflow

---------

Co-authored-by: Gabriel Demichelis <[email protected]>

* Apply designer's feedback on animation colors

* Revert accidental change

---------

Co-authored-by: Wesley Berrêdo <[email protected]>
Co-authored-by: Luiz Kowalski <[email protected]>
Co-authored-by: Dave Martin <[email protected]>
Co-authored-by: leonardost <[email protected]>
Co-authored-by: Andrés Blanco <[email protected]>
Co-authored-by: Andrés Blanco <[email protected]>
Co-authored-by: Omar Alshaker <[email protected]>
Co-authored-by: Juan Lucha <[email protected]>
Co-authored-by: Edwin Takahashi <[email protected]>
Co-authored-by: Payton Swick <[email protected]>
Co-authored-by: TheSteveK <[email protected]>
Co-authored-by: Eric Binnion <[email protected]>
Co-authored-by: Candy Tsai <[email protected]>
Co-authored-by: Harris Papazoglou <[email protected]>
Co-authored-by: cpap <[email protected]>
Co-authored-by: Addison Stavlo <[email protected]>
Co-authored-by: daledupreez <[email protected]>
Co-authored-by: Daniel <[email protected]>
Co-authored-by: Sérgio Gomes <[email protected]>
Co-authored-by: Chris R <[email protected]>
Co-authored-by: Grzegorz Chudzinski-Pawlowski <[email protected]>
Co-authored-by: Jason Moon <[email protected]>
Co-authored-by: Jeremy Yip <[email protected]>
Co-authored-by: Noah Allen <[email protected]>
Co-authored-by: Heyde Moura <[email protected]>
Co-authored-by: ouikhuan <[email protected]>
Co-authored-by: Yashwin Poojary <[email protected]>
Co-authored-by: Francesco Bigiarini <[email protected]>
Co-authored-by: Dan Speckhard Pasque <[email protected]>
Co-authored-by: arthur791004 <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Hannah Tinkler <[email protected]>
Co-authored-by: Dean Sas <[email protected]>
Co-authored-by: Bryan Elliott <[email protected]>
Co-authored-by: Derek Smart <[email protected]>
Co-authored-by: Caroline Moore <[email protected]>
Co-authored-by: James Tien <[email protected]>
Co-authored-by: Dehan <[email protected]>
Co-authored-by: Dylan Munson <[email protected]>
Co-authored-by: Anthony Grullon <[email protected]>
Co-authored-by: Matias Ventura <[email protected]>
Co-authored-by: Anna McPhee <[email protected]>
Co-authored-by: Dognose <[email protected]>
Co-authored-by: Luis Felipe Zaguini <[email protected]>
Co-authored-by: Renan Carvalho <[email protected]>
Co-authored-by: Marin Atanasov <[email protected]>
Co-authored-by: Chris Diehl <[email protected]>
Co-authored-by: Chris Diehl <[email protected]>
Co-authored-by: Gabriel Demichelis <[email protected]>
Co-authored-by: Jasper Kang <[email protected]>
Co-authored-by: Ashar Fuadi <[email protected]>
Co-authored-by: Griffith Chen <[email protected]>
Co-authored-by: Bogdan Nikolic <[email protected]>
@noahtallen
Copy link
Contributor Author

Thanks @yashwin -- I thought the label text was hidden when making the change, so I didn't catch this. thanks for the fix!

@a8ci18n
Copy link

a8ci18n commented Jul 27, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.