Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wordpress packages (again) #79647

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Update wordpress packages (again) #79647

merged 2 commits into from
Jul 25, 2023

Conversation

noahtallen
Copy link
Contributor

While working on #78711, some new versions came out. So this PR actually updates these packages to the latest version. Hopefully we can get Renovate running soon to automate this again!

To do:

see what CI comes up with!

Testing instructions:

  • CI should pass
  • Smoke test Calypso and the major workflows

@noahtallen noahtallen requested a review from a team July 19, 2023 22:47
@noahtallen noahtallen self-assigned this Jul 19, 2023
@noahtallen noahtallen requested review from a team and worldomonation as code owners July 19, 2023 22:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 19, 2023
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

.yarnrc.yml Outdated
@@ -62,25 +62,34 @@ packageExtensions:
"@signal-noise/[email protected]":
peerDependencies:
postcss: "*"
"@wordpress/[email protected]":
"@wordpress/[email protected]":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it seems like these peer dependency issues are regressing. About two years ago, I got everything fixed internal to Gutenberg, but seems like that's stopped happening again, leaving these issues scattered about everywhere.

package.json Outdated
"@wordpress/core-data": "6.12.0",
"@wordpress/create-block-tutorial-template": "2.24.0",
"@wordpress/create-block": "4.20.0",
"@wordpress/a11y": "3.37.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used our new script to update all these, and it worked great

@matticbot
Copy link
Contributor

matticbot commented Jul 19, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~764 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-domains-landing      +5598 B  (+0.9%)    +1371 B  (+0.8%)
entry-stepper              +3979 B  (+0.2%)     +764 B  (+0.1%)
entry-main                 +3979 B  (+0.2%)     +764 B  (+0.2%)
entry-subscriptions        +3975 B  (+0.3%)     +762 B  (+0.2%)
entry-login                +3681 B  (+0.3%)     +653 B  (+0.2%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~13259 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
pattern-assembler-step     +43235 B  (+2.7%)   +13260 B  (+2.9%)
import-flow                +43235 B  (+1.3%)   +13259 B  (+1.5%)
gutenberg-editor             +594 B  (+0.1%)     +173 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~13248 bytes added 📈 [gzipped])

name                                                                         parsed_size           gzip_size
async-load-automattic-global-styles-src-components-global-styles-variations     +43235 B  (+3.1%)   +13260 B  (+3.2%)
async-load-automattic-design-preview                                            +43235 B  (+3.0%)   +13260 B  (+3.2%)
async-load-calypso-layout-masterbar-checkout-tsx                                  +294 B  (+0.2%)     +109 B  (+0.3%)
async-load-design-wordpress-components-gallery                                     -39 B  (-0.0%)      -41 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications update-wordpress-round-2 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

@matticbot
Copy link
Contributor

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit update-wordpress-round-2 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we might have to accommodate the changes from #79675.

@noahtallen noahtallen force-pushed the update-wordpress-round-2 branch 2 times, most recently from 095bd2e to 86996f6 Compare July 20, 2023 18:40
@noahtallen
Copy link
Contributor Author

Rebased!

@noahtallen noahtallen requested a review from tyxla July 20, 2023 21:00
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested a few signup and checkout flows, as well as some logged-in and logged-out Calypso pages, then compared the devdocs WP components pages for desert.

Everything looks good and safe to go 🚀

Thanks @noahtallen, exciting to see us finally reach the destination 🙌

@noahtallen noahtallen force-pushed the update-wordpress-round-2 branch from 86996f6 to c872b0b Compare July 24, 2023 23:47
@noahtallen
Copy link
Contributor Author

I'll deploy tomorrow, though you don't need to wait for me!

@noahtallen noahtallen force-pushed the update-wordpress-round-2 branch from c872b0b to 029258c Compare July 25, 2023 22:07
@noahtallen noahtallen merged commit cbbd06f into trunk Jul 25, 2023
@noahtallen noahtallen deleted the update-wordpress-round-2 branch July 25, 2023 22:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants