-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wordpress packages (again) #79647
Conversation
.yarnrc.yml
Outdated
@@ -62,25 +62,34 @@ packageExtensions: | |||
"@signal-noise/[email protected]": | |||
peerDependencies: | |||
postcss: "*" | |||
"@wordpress/[email protected]": | |||
"@wordpress/[email protected]": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, it seems like these peer dependency issues are regressing. About two years ago, I got everything fixed internal to Gutenberg, but seems like that's stopped happening again, leaving these issues scattered about everywhere.
package.json
Outdated
"@wordpress/core-data": "6.12.0", | ||
"@wordpress/create-block-tutorial-template": "2.24.0", | ||
"@wordpress/create-block": "4.20.0", | ||
"@wordpress/a11y": "3.37.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used our new script to update all these, and it worked great
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~764 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~13259 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~13248 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for notifications To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-elI-p2 |
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we might have to accommodate the changes from #79675.
095bd2e
to
86996f6
Compare
Rebased! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested a few signup and checkout flows, as well as some logged-in and logged-out Calypso pages, then compared the devdocs WP components pages for desert.
Everything looks good and safe to go 🚀
Thanks @noahtallen, exciting to see us finally reach the destination 🙌
86996f6
to
c872b0b
Compare
I'll deploy tomorrow, though you don't need to wait for me! |
c872b0b
to
029258c
Compare
While working on #78711, some new versions came out. So this PR actually updates these packages to the latest version. Hopefully we can get Renovate running soon to automate this again!
To do:
see what CI comes up with!
Testing instructions: