Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Settings: Fix staging site toggle label #79664

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

Initsogar
Copy link
Contributor

@Initsogar Initsogar commented Jul 20, 2023

The ToggleControl component requires a label prop according to its type definition, based on that, it was added the label prop in #78711 when updating @wordpress/components packages in Calypso.

The purpose of this PR is to move the toggle description to the label prop.

Proposed Changes

  • Move the Jetpack staging site setting toggle description into the label prop in ToggleControl component to remove redundant texts.
Before After
image image

Testing Instructions

  • Using a site with Jetpack VaultPress Backup and server credentials configured, navigate to Jetpack Cloud's settings page and ensure the Set up as staging site setting looks like the After screenshot.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@Initsogar Initsogar added Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) [Feature] Backups The Jetpack Backup product labels Jul 20, 2023
@Initsogar Initsogar self-assigned this Jul 20, 2023
@Initsogar Initsogar requested a review from a team July 20, 2023 02:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2023
@Initsogar Initsogar requested a review from noahtallen July 20, 2023 02:58
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes removed 📉 [gzipped])

name                    parsed_size           gzip_size
jetpack-cloud-settings        -92 B  (-0.0%)      -22 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@Initsogar Initsogar merged commit 48b1183 into trunk Jul 21, 2023
@Initsogar Initsogar deleted the fix/jetpack-staging-site-toggle branch July 21, 2023 00:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Backups The Jetpack Backup product Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants