chore: upgrade jest (and related packages) to v29 #78786

flootr · 2023-06-29T14:39:44Z

Related to #78711

Proposed Changes

PR upgrades Jest (and related packages where necessary) to v29. We're currently on v27 which means we're jumping two major versions.

Testing Instructions

Verify all tests are green

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

github-actions · 2023-06-29T14:39:58Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-73213

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-73213&env=jetpack

matticbot · 2023-06-29T14:49:58Z

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit chore/update/jest-v29 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

matticbot · 2023-06-29T14:52:53Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~113 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-domains-landing       +151 B  (+0.0%)     +124 B  (+0.1%)
entry-subscriptions          +51 B  (+0.0%)     +113 B  (+0.0%)
entry-stepper                +51 B  (+0.0%)     +113 B  (+0.0%)
entry-main                   +51 B  (+0.0%)     +113 B  (+0.0%)
entry-login                  +51 B  (+0.0%)     +113 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

matticbot · 2023-07-04T10:10:26Z

This PR modifies the release build for notifications

To test your changes on WordPress.com, run install-plugin.sh notifications chore/update/jest-v29 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-elI-p2

matticbot · 2023-07-04T10:10:33Z

This PR modifies the release build for wpcom-block-editor

To test your changes on WordPress.com, run install-plugin.sh wpcom-block-editor chore/update/jest-v29 on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-l4k-p2

noahtallen · 2023-07-07T00:34:51Z

Migrated ETK and Odyssey stats to the shared testing config here: #79097

tyxla · 2023-07-07T10:30:10Z

Migrated ETK and Odyssey stats to the shared testing config here: #79097

Looks great and works well in my testing. Looking forward to it unblocking this one 🚀

noahtallen · 2023-07-08T00:19:24Z

Hey @flootr, I rebased this after merging #79097. I ran into some weird conflicts, so I ultimately removed a couple commits and did another dedupe after running yarn up jest babel-jest 'jest-*' again.

While I was rebasing, I also forgot for a moment that I was rebasing and ended up finding a simpler fix for the e2e config type issue 😅

I also don't think we need @types/jest anymore -- npm reports that jest bundles it's own types now (https://www.npmjs.com/package/jest), so I removed it. I also removed jest itself from devDependencies in a handful of Calypso apps which don't use it

tyxla · 2023-07-10T17:55:43Z

Hey @flootr, I rebased this after merging #79097. I ran into some weird conflicts, so I ultimately removed a couple commits and did another dedupe after running yarn up jest babel-jest 'jest-*' again.

While I was rebasing, I also forgot for a moment that I was rebasing and ended up finding a simpler fix for the e2e config type issue 😅

I also don't think we need @types/jest anymore -- npm reports that jest bundles it's own types now (https://www.npmjs.com/package/jest), so I removed it. I also removed jest itself from devDependencies in a handful of Calypso apps which don't use it

Neat! Aside from this needing a rebase, I guess it should also wait for #79176 to land since #79097 got reverted.

For the protocol, #79176 is approved and can be merged already.

noahtallen · 2023-07-10T20:03:52Z

Aside from this needing a rebase

done and marked as ready for final review! 🎉

noahtallen

Looks good to me!

I noticed this line of code last week; we might be able to remove it:

wp-calypso/test/client/setup-test-framework.js

Lines 43 to 48 in 1043c24

    
           // TODO: structuredClone wasn't available in Jest before verson 28 so this creates 
        
           // a version to be used for the tests. Once Jest is upgraded to 28 this should 
        
           // be removed. 
        
           global.structuredClone = jest.fn( ( value ) => { 
        
           	return JSON.parse( JSON.stringify( value ) ); 
        
           } );

noahtallen · 2023-07-10T20:49:45Z

client/state/data-layer/wpcom/gravatar-upload/test/index.js

@@ -54,10 +54,6 @@ describe( '#announceSuccess()', () => {
 			},
 		} ) );
 	} );
-	afterAll( () => {


Do we still need to restore the previous FormData implementation?

I don't think we need it; just removed it.

tyxla · 2023-07-11T08:43:44Z

I noticed this line of code last week; we might be able to remove it:

Good spot, removed.

tyxla

Works well for me and the codechanges make sense! Nice work y'all!

LGTM 🚢

tyxla · 2023-07-11T09:05:20Z

I'll proceed to ship this one.

flootr added [Type] Janitorial Testing labels Jun 29, 2023

flootr self-assigned this Jun 29, 2023

flootr force-pushed the chore/update/jest-v29 branch 2 times, most recently from 77c2f42 to f6fcc0f Compare July 4, 2023 08:09

noahtallen mentioned this pull request Jul 7, 2023

Migrate apps unit tests away from wp scripts #79097

Merged

tyxla mentioned this pull request Jul 7, 2023

Update wordpress packages to the latest version #78711

Merged

17 tasks

noahtallen force-pushed the chore/update/jest-v29 branch from 384f193 to 519c25d Compare July 8, 2023 00:18

flootr mentioned this pull request Jul 10, 2023

Migrate apps unit tests away from wp scripts 2nd take #79176

Merged

flootr and others added 12 commits July 10, 2023 13:01

chore(jest): upgrade jest & jdom to v29

c121a7b

chore(jest): apply configuration changes

13aea9e

chore: upgrade more jest related packages

0733f2a

chore: upgrade jest-mock-process to v2

12cc43e

try: weird dependency stuff

53292d9

fix a few type errors in calypso-e2e

cfb666b

fix some unit tests

f9b1374

fix unit tests for sanitizeSectionContent

7ecb684

client: upgrade @emotion/jest

02b0c42

Dedupe and update again

8157404

Remove jest from a few packages which don't use it

39a029e

Remove @types/jest

81b5ecf

Simplify e2e environment types

a6c43ca

noahtallen force-pushed the chore/update/jest-v29 branch from 27d32c5 to a6c43ca Compare July 10, 2023 20:03

noahtallen marked this pull request as ready for review July 10, 2023 20:03

noahtallen requested review from a team and worldomonation as code owners July 10, 2023 20:03

matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 10, 2023

noahtallen approved these changes Jul 10, 2023

View reviewed changes

tyxla added 2 commits July 11, 2023 11:40

Remove unnecessary structuredClone polyfill

de89635

Cleanup unnecessary FormData mock

0edb5d0

tyxla approved these changes Jul 11, 2023

View reviewed changes

tyxla merged commit 4fa6fa7 into trunk Jul 11, 2023

tyxla deleted the chore/update/jest-v29 branch July 11, 2023 09:05

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: upgrade jest (and related packages) to v29 #78786

chore: upgrade jest (and related packages) to v29 #78786

flootr commented Jun 29, 2023 •

edited by noahtallen

Loading

github-actions bot commented Jun 29, 2023 •

edited by matticbot

Loading

matticbot commented Jun 29, 2023

matticbot commented Jun 29, 2023 •

edited

Loading

matticbot commented Jul 4, 2023

matticbot commented Jul 4, 2023

noahtallen commented Jul 7, 2023

tyxla commented Jul 7, 2023

noahtallen commented Jul 8, 2023 •

edited

Loading

tyxla commented Jul 10, 2023 •

edited

Loading

noahtallen commented Jul 10, 2023

noahtallen left a comment

noahtallen Jul 10, 2023

tyxla Jul 11, 2023

tyxla commented Jul 11, 2023

tyxla left a comment

tyxla commented Jul 11, 2023

	// TODO: structuredClone wasn't available in Jest before verson 28 so this creates
	// a version to be used for the tests. Once Jest is upgraded to 28 this should
	// be removed.
	global.structuredClone = jest.fn( ( value ) => {
	return JSON.parse( JSON.stringify( value ) );
	} );

chore: upgrade jest (and related packages) to v29 #78786

chore: upgrade jest (and related packages) to v29 #78786

Conversation

flootr commented Jun 29, 2023 • edited by noahtallen Loading

Proposed Changes

Testing Instructions

Pre-merge Checklist

github-actions bot commented Jun 29, 2023 • edited by matticbot Loading

matticbot commented Jun 29, 2023

matticbot commented Jun 29, 2023 • edited Loading

matticbot commented Jul 4, 2023

matticbot commented Jul 4, 2023

noahtallen commented Jul 7, 2023

tyxla commented Jul 7, 2023

noahtallen commented Jul 8, 2023 • edited Loading

tyxla commented Jul 10, 2023 • edited Loading

noahtallen commented Jul 10, 2023

noahtallen left a comment

Choose a reason for hiding this comment

noahtallen Jul 10, 2023

Choose a reason for hiding this comment

tyxla Jul 11, 2023

Choose a reason for hiding this comment

tyxla commented Jul 11, 2023

tyxla left a comment

Choose a reason for hiding this comment

tyxla commented Jul 11, 2023

flootr commented Jun 29, 2023 •

edited by noahtallen

Loading

github-actions bot commented Jun 29, 2023 •

edited by matticbot

Loading

matticbot commented Jun 29, 2023 •

edited

Loading

noahtallen commented Jul 8, 2023 •

edited

Loading

tyxla commented Jul 10, 2023 •

edited

Loading