Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Pro Dashboard: visually hide the label of the toggle control in the monitor notification settings popup. #79777

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Jul 24, 2023

Related to 1202619025189113-as-1205119881383168

Proposed Changes

This PR added a label to the ToggleControl component, which broke the UI in the Jetpack Pro Dashboard(Downtime Monitor Notification Settings popup). So we have made some changes to visually hide the toggle control label by positioning it far off-screen, making it effectively invisible so that it will still be used by screen readers.

Testing Instructions

Prerequisites

Since these changes are made specifically for agencies, you must set yourself(partner) as an agency - 2c49b-pb. Make sure to switch it back to the previous type.

Instructions

  1. Run git checkout add/url-support-open-license-info-popup and yarn start-jetpack-cloud or open the Jetpack Cloud live link.
  2. Open http://jetpack.cloud.localhost:3000/, and you'll be redirected to the /dashboard.
  3. Enable monitor if not enabled already.
  4. Click on the clock icon next to the monitor toggle.
  5. Verify the label for the mobile, push, and email notification toggle is no more visible.
  6. Turn on the voiceover and verify that the toggle still reads the correct aria label.
Before After
Screenshot 2023-07-24 at 11 29 39 AM Screenshot 2023-07-24 at 12 39 02 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@yashwin yashwin added Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Jul 24, 2023
@yashwin yashwin requested a review from a team July 24, 2023 07:16
@yashwin yashwin self-assigned this Jul 24, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 24, 2023
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~12 bytes added 📈 [gzipped])

name                            parsed_size           gzip_size
jetpack-cloud-agency-dashboard       +150 B  (+0.0%)      +12 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@jkguidaven jkguidaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks for working on this quickly 👍

@yashwin yashwin merged commit c5a9367 into trunk Jul 24, 2023
@yashwin yashwin deleted the fix/visually-hide-label-of-toggle-control branch July 24, 2023 08:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants