This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Featured Category block: add support for global style #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…products-block into add/4965-product-title
gigitux
added
type: enhancement
18 tasks
gigitux
force-pushed
the
add/4965-featured-category
branch
from
0a96add to
3dc70d9
Compare
Featured Category block: Add support for global style
gigitux
force-pushed
the
add/4965-featured-category
branch
2 times, most recently
from
5892079 to
1826f91
Compare
gigitux
force-pushed
the
add/4965-featured-category
branch
2 times, most recently
from
98059dc to
6ea99a2
Compare
|
Size Change: +895 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
gigitux
force-pushed
the
add/4965-featured-category
branch
from
6ea99a2 to
201d8ed
Compare
gigitux
commented
Jan 12, 2022
| @@ -325,7 +308,10 @@ const FeaturedCategory = ( { | |||
| return ( | |||
| <ResizableBox | |||
| className={ classes } | |||
| size={ { height } } | |||
| size={ { | |||
There was a problem hiding this comment.
I think that we should not limit the height in the editor.
Now the user can change the font-size. If the font-size is high, the block should become bigger otherwise the user can't see the entire text.
gigitux
force-pushed
the
add/4965-featured-category
branch
from
201d8ed to
126e9b5
Compare
…products-block into add/4965-featured-category
gigitux
force-pushed
the
add/4965-featured-category
branch
from
126e9b5 to
c2cab62
Compare
gigitux
added
the
status: blocker
This was referenced Jan 13, 2022
gigitux
removed
the
status: blocker
dinhtungdu
reviewed
Jan 19, 2022
There was a problem hiding this comment.
@gigitux Overall, the block style and global style are working as expected. But there are some things we can improve:
The background is different between editors (both Blocks and Site Editors) and the front-end. In the Blocks Editor, changing the background Opacity doesn't update the style of the preview block.
Screenshot
When the border-radius is set, there are small curves at four corners of the block. This happens because we set the border-radius for both wrapper and overlay elements.
Screenshot
The preset font sizes in the editors don't match corresponding ones on the front-end. Look like this issue occurs in other blocks, if so we can address it in a separated PR.
Screenshot
…products-block into add/4965-featured-category
gigitux
force-pushed
the
add/4965-featured-category
branch
from
78846a5 to
3effda7
Compare
|
Thanks for the review! I fixed the issue about the For the font-size, I have always the same value (I'm using Edge):
|
dinhtungdu
reviewed
Jan 23, 2022
Comment on lines
42
to
45
| color: { | ||
| text: true, | ||
| background: true, | ||
| }, |
There was a problem hiding this comment.
Background and text color are enabled by default so this can be shortened like this:
Suggested change
| color: { | |
| text: true, | |
| background: true, | |
| }, | |
| color: true, |
dinhtungdu
approved these changes
Jan 23, 2022
Comment on lines
2
to
5
| border-color: transparent; | ||
| overflow: hidden; | ||
| color: #fff; | ||
| background-color: #000; |
There was a problem hiding this comment.
Can we order CSS properties alphabetically? It's easier to maintain.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5515This PR adds support for global style for the
Featured Category block.Now, the user can edit the style for:
What missing:
Duotone
At this stage, the
Duotonefeature is implemented with thefilterCSS property. The problem is that on this block, the image is implemented likebackground-image, so we can't use thefilterproperty.Padding
At this stage, with the current global style API, the padding is applied to the entire wrapper, so I guess that it doesn't make sense enable it.
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9, install and enable theGutenbergplugin.Twenty Twenty-Twotheme.Featured Category Blockto a post.Resetbutton from the different sections.Stylesicon on the right-top corner.Featured Category blockis shown under theBlockssection. Personalize again the block.Changelog