This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Product Image block: Enable global style #5562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…products-block into add/4965-product-title
Featured Category block: Add support for global style
…products-block into add/4965-featured-category
…oocommerce-gutenberg-products-block into add/4965-image
gigitux
added
status: blocked
rubikuserbot
requested review from
a team and
tjcafferkey
and removed request for
a team
Product Image block: enable global style #4965
gigitux
force-pushed
the
add/4965-image
branch
from
79a6695 to
638d40a
Compare
|
Size Change: +513 B (0%) Total Size: 813 kB
ℹ️ View Unchanged
|
18 tasks
gigitux
removed
the
status: blocked
…products-block into add/4965-image
gigitux
force-pushed
the
add/4965-image
branch
from
0d52663 to
623865d
Compare
tjcafferkey
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
This works great for me and the code LGTM too. My only problem is from a UX perspective, at first I thought the "Border radius" option was missing on the Site Editor because it was hidden behind "Layout" instead of being alongside "Typography' like on the Edit Page view:
Edit Page
Site Editor
Thanks for the review! Good point. Unfortunately, this UI/UX is handled by Gutenberg :/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5542This PR adds support for global style for the
Product Image block.Now, the user can edit the style for:
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9, install and enable theGutenbergplugin.Twenty Twenty-Twotheme.Single Product block(this block containsProduct Image Block) to a post.Product Image Block.Resetbutton from the different sections.Stylesicon on the right-top corner.Product Image blockis shown under theBlockssection. Personalize again the block.Changelog