This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Sale Product Block: Enable global style #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…products-block into add/4965-product-title
Featured Category block: Add support for global style
…products-block into add/4965-featured-category
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
|
Size Change: +923 B (0%) Total Size: 814 kB
ℹ️ View Unchanged
|
Sale Product block: enable global style #4965
gigitux
force-pushed
the
add/4965-sale-product
branch
from
8386b5c to
d33c181
Compare
gigitux
added
focus: global styles
…oocommerce-gutenberg-products-block into add/4965-sale-product
gigitux
force-pushed
the
add/4965-sale-product
branch
from
d33c181 to
19f5f54
Compare
18 tasks
gigitux
force-pushed
the
add/4965-sale-product
branch
from
0f57f3e to
0d69454
Compare
…products-block into add/4965-sale-product
gigitux
force-pushed
the
add/4965-sale-product
branch
from
0d69454 to
9711034
Compare
…products-block into add/4965-sale-product
dinhtungdu
approved these changes
Feb 13, 2022
There was a problem hiding this comment.
This is look good to me. Even the block registration looks a little bit confusing, I think we can always address that issue later when we have another atomic block that needs __experimentalSelector support. __experimentalSelector, by its name, is experimental, so it can be changed in the future Gutenberg release, so it isn't worth addressing it now.
| @@ -178,6 +178,7 @@ protected function get_block_types() { | |||
| 'ProductTitle', | |||
| 'ProductSummary', | |||
| 'ProductStockIndicator', | |||
| 'ProductSaleBadge', | |||
There was a problem hiding this comment.
I think a comment here explaining why we register an atomic block here will be helpful.
There was a problem hiding this comment.
Good point! I added a @todo comment. In this way, in the end, I will re-organize the order of the elements in the array (maybe we can move down the atomic blocks and add a comment that explains why)
Add a comment why some atomic blocks are included in this...Add a comment why some atomic blocks are included in this array. https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/19c03410409ac44660859d81d30cdcc60b4a3f8e/src/BlockTypesController.php#L156-L159🚀 This comment was generated by the automations bot based on a
|
sunyatasattva
added
the
type: enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5542This PR adds support for global style for the
Sale Product block. This code registers the block on the PHP side. This is necessary for using the__experimentalSelectorfrom Global Styles API.Now, the user can edit the style for:
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
Twenty Twenty-Twotheme.All Product Blockto a post.Stylesicon on the right-top corner.Sale Product blockis shown under theBlockssection. Click on the label. Personalize the block.Changelog