This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Featured Product: Enable global style #5555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…products-block into add/4965-product-title
Featured Category block: Add support for global style
…oocommerce-gutenberg-products-block into add/4965-featured-product
…oocommerce-gutenberg-products-block into add/4965-featured-product
Featured Product block: enable global style
…products-block into add/4965-featured-category
…products-block into add/4965-featured-product
rubikuserbot
requested review from
a team and
Aljullu
and removed request for
a team
|
Size Change: +75 B (0%) Total Size: 816 kB
ℹ️ View Unchanged
|
gigitux
force-pushed
the
add/4965-featured-product
branch
from
0dd39a3 to
d77e39b
Compare
gigitux
added
focus: FSE
gigitux
added
the
status: blocked
18 tasks
…products-block into add/4965-featured-category
…oocommerce-gutenberg-products-block into add/4965-featured-product
Aljullu
reviewed
Jan 31, 2022
| background-size: cover; | ||
| background-position: center center; | ||
| width: 100%; | ||
| margin: 0 0 1.5em 0; | ||
| margin: 0 0 0 0; |
There was a problem hiding this comment.
Should we use the shorthand here?
Suggested change
| margin: 0 0 0 0; | |
| margin: 0; |
Comment on lines
285
to
288
| size={ { | ||
| height: '', | ||
| width: '', | ||
| } } |
There was a problem hiding this comment.
How does that work? I seem to be able to change the height of the block, but not the width. Is that the expected behavior?
There was a problem hiding this comment.
I think that we should not limit the height of the editor.
Now the user can change the font size. If the font size is high, the block should become bigger otherwise the user can't see the entire text.
In accordance with TS type, we need to specify either height and width
There was a problem hiding this comment.
Now that the font size can't be modified anymore, should we undo this change?
| background-size: cover; | ||
| background-position: center center; | ||
| width: 100%; | ||
| margin: 0 0 1.5em 0; | ||
| margin: 0 0 0 0; |
There was a problem hiding this comment.
Here too:
Suggested change
| margin: 0 0 0 0; | |
| margin: 0; |
| line-height: 1.25; | ||
| margin-bottom: 0; | ||
| text-align: center; | ||
| color: inherit; | ||
| font-size: inherit; |
There was a problem hiding this comment.
Personally, I think the .wc-block-featured-product__title shouldn't have font-size: inherit;. That changes the default design:
trunk |
This branch |
|---|---|
 |
 |
What do you think?
There was a problem hiding this comment.
You are right!
This is a bug that affects Featured Category too :( (already merged in the trunk), but this bug is replicable only when the site has a block theme enabled.
The Global Styles API doesn't support different font-size options, so we can:
- disable the font size option.
- font size option will impact only the description (it doesn't make sense IMHO).
There was a problem hiding this comment.
In the end, I followed the same approach that we adopted in #5682: the user can't customize font-size
…products-block into add/4965-featured-product
gigitux
force-pushed
the
add/4965-featured-product
branch
from
e8cc16c to
b4ffeed
Compare
…products-block into add/4965-featured-product
gigitux
force-pushed
the
add/4965-featured-product
branch
from
82f8d8f to
0261501
Compare
Aljullu
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
I left one last comment, but besides that, everything looks good to me, so pre-approving.
…products-block into add/4965-featured-product
|
Thanks for the review! |
4 tasks
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is blocked by #5542
This PR adds support for global style for the
Featured Product block.Now, the user can edit the style for:
What missing:
Duotone
At this stage, the
Duotonefeature is implemented with thefilterCSS property. The problem is that on this block, the image is implemented likebackground-image, so we can't use thefilterproperty.Padding
At this stage, with the current global style API, the padding is applied to the entire wrapper, so I guess that it doesn't make sense enable it.
#4965
Screenshots
without global style
with global style
Testing
Manual Testing
Check out this branch:
WordPress 5.9, install and enable theGutenbergplugin.Twenty Twenty-Twotheme.Featured Product blockto a post.Resetbutton from the different sections.Stylesicon on the right-top corner.Featured Product blockis shown under theBlockssection. Personalize again the block.Changelog