-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display extra details from new PHAF file #2029
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Show we can show the condition details on the website. Refs pombase/website#2029
How's this for displaying the extra condition details? The prototype is here: https://desktop.kmr.nz/term/FYPO:0000797 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Ah yes! That looks good |
When we announce this we should say that the temperature and concentration can only be collected for HTP submission at present , and update the docs there to specify exactly the format for including temperature and concentration and score. https://www.pombase.org/documentation/phenotype-data-bulk-upload-format |
That's working now. Here's good example: https://pombase.org/genotype/alg6delta |
I wonder if we could tidy the syntax of these fields a little so that it will be consistent when I document that these values are allowed for HTP data Percentage are usually (0.1%) but occasionally 2 % (with or without space) Molarity is usually (20mM) but sometimes (20 mM) (with or without space) Somemtimes (2.5 % v/v) and sometimes (2 % (w/v)) ( different use of brackets) Just on https://pombase.org/genotype/alg6delta Is it usual to mix molarity, ratio µg/ml, percentages in a single study? Anyway, just standardizing use of spaces and brackets would be helpful. |
Fixes problem with with 29e7f69 Refs pombase/website#2029
Moved to: pombase/curation#3627 |
Still need to display:
We also have "allele variant" from the PHAF files. Maybe that doesn't need to be displayed? |
"allele variant" |
They are the longer allele descriptions using chromosome coordinates like this:
We haven't included these strings for all alleles yet but there are examples in the last column of this file:
|
I don't think we need to display it one the gene pages , but it could eventually be added to the allele pages as additional information? |
Yep, maybe on the allele pages at some point. But it's probably more useful as bulk download data in the PHAF files. |
Should these be display on the website? Should we display them in the same style as extensions like we do for severity ("has severity high")?: normalised_difference -0.4234 |
I'm not sure @manulera will these be meaningful to users? |
Hi both, I think this may make sense in the publication pages, to compare two phenotypes since these numbers are only relevant when comparing phenotypes obtained in the same experiment. Not critical, but it can be neat. In the gene page I don't think they would be useful. |
That's a good plan, only on the publication page for this detail. |
Only show the column if data is available. Refs #2029
The field name is "annotation_phenotype_score" Refs pombase/website#2029
Thanks Manu. Good plan.
That's implemented and will be on the main site tomorrow. The new column is only visible in the detailed view and only on this page: https://www.pombase.org/reference/PMID:34984977 Let me know if the column name needs changing. Unfortunately that page is still slow to load but I'm working on it: #2100 |
If there's anything needed, let's open new issues. |
See: pombase/pombase-chado#1066
feature_cvtermprop
)Edit: Some documentation
The text was updated successfully, but these errors were encountered: