Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display extra details from new PHAF file #2029

Closed
kimrutherford opened this issue Mar 23, 2023 · 23 comments
Closed

Display extra details from new PHAF file #2029

kimrutherford opened this issue Mar 23, 2023 · 23 comments

Comments

@kimrutherford
Copy link
Member

kimrutherford commented Mar 23, 2023

See: pombase/pombase-chado#1066

  • allele variant ( add url for genotype format variant syntax)
  • condition details:
    • Temperature (degrees C)
    • Chemical or agent (concentration units)
  • Chemical or agent dose
  • Phenotype score / Phenotype score units
    • fitness_log2(0.123)
    • normalised_difference(-0.4234)
    • stored as properties in Chado (in feature_cvtermprop)

Edit: Some documentation

@kimrutherford

This comment was marked as outdated.

@kimrutherford

This comment was marked as outdated.

@ValWood

This comment was marked as outdated.

kimrutherford added a commit to pombase/pombase-chado that referenced this issue Nov 13, 2023
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Nov 13, 2023
Show we can show the condition details on the website.

Refs pombase/website#2029
@kimrutherford
Copy link
Member Author

How's this for displaying the extra condition details?

The prototype is here: https://desktop.kmr.nz/term/FYPO:0000797

image

@ValWood

This comment was marked as resolved.

@kimrutherford

This comment was marked as resolved.

@manulera
Copy link
Contributor

Ah yes! That looks good

kimrutherford added a commit that referenced this issue Nov 13, 2023
@kimrutherford
Copy link
Member Author

Looks good!

Great. The changes will be visible in the morning.

We may need to tweak the formatting a bit because sometimes the details wrap onto the next line and look odd:

image

@ValWood
Copy link
Member

ValWood commented Nov 13, 2023

When we announce this we should say that the temperature and concentration can only be collected for HTP submission at present , and update the docs there to specify exactly the format for including temperature and concentration and score.

https://www.pombase.org/documentation/phenotype-data-bulk-upload-format

@kimrutherford
Copy link
Member Author

The changes will be visible in the morning.

That's working now. Here's good example: https://pombase.org/genotype/alg6delta

@ValWood
Copy link
Member

ValWood commented Nov 15, 2023

I wonder if we could tidy the syntax of these fields a little so that it will be consistent when I document that these values are allowed for HTP data

Percentage are usually (0.1%) but occasionally 2 % (with or without space)

Molarity is usually (20mM) but sometimes (20 mM) (with or without space)

Somemtimes (2.5 % v/v) and sometimes  (2 % (w/v)) ( different use of brackets)

Just on https://pombase.org/genotype/alg6delta

Is it usual to mix molarity, ratio µg/ml, percentages in a single study?

Anyway, just standardizing use of spaces and brackets would be helpful.

kimrutherford added a commit to pombase/pombase-chado that referenced this issue Nov 22, 2023
@kimrutherford
Copy link
Member Author

I wonder if we could tidy the syntax of these fields a little so that it will be consistent when I document that these values are allowed for HTP data

Moved to: pombase/curation#3627

@kimrutherford
Copy link
Member Author

kimrutherford commented Dec 7, 2023

Still need to display:

  • Chemical or agent dose - already covered by the values attached to the FYECO terms
  • Phenotype score / Phenotype score units:
    • fitness_log2(0.123)
    • normalised_difference(-0.4234)

We also have "allele variant" from the PHAF files. Maybe that doesn't need to be displayed?

@ValWood
Copy link
Member

ValWood commented Dec 7, 2023

"allele variant"
what is that ? isn't it just the allele description?

@kimrutherford
Copy link
Member Author

"allele variant"
what is that ? isn't it just the allele description?

They are the longer allele descriptions using chromosome coordinates like this:

III:g.217516_218406del

We haven't included these strings for all alleles yet but there are examples in the last column of this file:

pombe-embl/external_data/phaf_files/chado_load/htp_phafs/PMID_34984977_phaf.tsv

@ValWood
Copy link
Member

ValWood commented Dec 7, 2023

I don't think we need to display it one the gene pages , but it could eventually be added to the allele pages as additional information?

@kimrutherford
Copy link
Member Author

Yep, maybe on the allele pages at some point. But it's probably more useful as bulk download data in the PHAF files.

@kimrutherford
Copy link
Member Author

  • Phenotype score / Phenotype score units:
    • fitness_log2(0.123)
    • normalised_difference(-0.4234)

Should these be display on the website?

Should we display them in the same style as extensions like we do for severity ("has severity high")?:

normalised_difference -0.4234
fitness_log2 0.123

@ValWood
Copy link
Member

ValWood commented Jan 29, 2024

I'm not sure @manulera will these be meaningful to users?

@manulera
Copy link
Contributor

manulera commented Jan 30, 2024

Hi both,

I think this may make sense in the publication pages, to compare two phenotypes since these numbers are only relevant when comparing phenotypes obtained in the same experiment. Not critical, but it can be neat.

In the gene page I don't think they would be useful.

@ValWood
Copy link
Member

ValWood commented Jan 30, 2024

That's a good plan, only on the publication page for this detail.

kimrutherford added a commit to pombase/pombase-config that referenced this issue Feb 5, 2024
kimrutherford added a commit that referenced this issue Feb 5, 2024
Only show the column if data is available.

Refs #2029
kimrutherford added a commit to pombase/pombase-chado-json that referenced this issue Feb 5, 2024
The field name is "annotation_phenotype_score"

Refs pombase/website#2029
@kimrutherford
Copy link
Member Author

I think this may make sense in the publication pages, to compare two phenotypes since these numbers are only relevant when comparing phenotypes obtained in the same experiment. Not critical, but it can be neat.

Thanks Manu. Good plan.

That's a good plan, only on the publication page for this detail.

That's implemented and will be on the main site tomorrow. The new column is only visible in the detailed view and only on this page: https://www.pombase.org/reference/PMID:34984977

Let me know if the column name needs changing.

Unfortunately that page is still slow to load but I'm working on it: #2100

image

@kimrutherford
Copy link
Member Author

If there's anything needed, let's open new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants