Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy syntax in new PHAF file fields #3627

Closed
kimrutherford opened this issue Dec 7, 2023 · 2 comments
Closed

Tidy syntax in new PHAF file fields #3627

kimrutherford opened this issue Dec 7, 2023 · 2 comments
Assignees

Comments

@kimrutherford
Copy link
Member

From: pombase/website#2029 (comment)

Should we remove all spaces? Maybe "(2.5% v/v)" needs a space though?


I wonder if we could tidy the syntax of these fields a little so that it will be consistent when I document that these values are allowed for HTP data

Percentage are usually (0.1%) but occasionally 2 % (with or without space)

Molarity is usually (20mM) but sometimes (20 mM) (with or without space)

Sometimes (2.5 % v/v) and sometimes (2 % (w/v)) ( different use of brackets)

Just on https://pombase.org/genotype/alg6delta

Is it usual to mix molarity, ratio µg/ml, percentages in a single study?

Anyway, just standardizing use of spaces and brackets would be helpful.

@ValWood
Copy link
Member

ValWood commented Dec 7, 2023

Maybe "(2.5% v/v)" needs a space though?
yep I think a space is required anywhere that the % is followed by another value

@kimrutherford
Copy link
Member Author

I've done that. The changes will be visible tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants