-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new PHAF columns #1066
Comments
Related to pombase/curation#3465 |
@kimrutherford I am almost done with the file, would just have to figure out those exceptional systematic ids and what the alleles should be called. Going swimming now but will check tomorrow 🏊 https://github.com/manulera/phenomics_paper_HTP/blob/master/results/pombase_dataset.tsv |
Thanks Manu. I've changed the loading code to handle the changes to the severity and condition columns. |
We'll be store it as a feature_cvtermprop instead. Refs pombase/pombase-chado#1066
We store in the feature_cvtermprop table. Refs #1066
I've changed the PHAF loader to store the We need to think about how and where to display the new information on the website. |
I've changed my mind on that. It can continue to be optional in the cases where there is no allele variant. |
I guess the assumption is haploid unless otherwise stated, but why does this have to do with the allele variant present or absent? |
I was thinking that we would need to put something in the "Ploidy" column only if we have an allele variant column. If there is no allele variant column, we won't need a "Ploidy" column. |
I am looking at the PHAF headers and I think I see what you mean, but I don't think this problem is restricted to the allele variant column. The headers are clearly meant to describe either haploids or homozygous diploids, but it is not clear how you would describe a heterozygous diploid. Separating allele names, expression levels and all with a spacer? Two lines for the same phenotype, but then what would be the unique identifier of the pair? You can call me on skype if you want to quickly discuss this. |
There isn't a way to store these in the PHAF file. The "Ploidy" column is a hack to allow loading the commonest diploids ("homozygous diploid"). That format doesn't support anything more complicated. We have plans for a new PHAF format to handle this problem (see #496) but we haven't implemented it yet. Stable allele identifiers will make this problem easier. |
Hi @manulera Sorry to come back to this after 2 weeks. In the new PHAF file ( Also should we include the unit ("C") after temperatures in conditions? Or is the unit obvious in that case? Here an example line that has examples of both questions:
Thanks! |
Hi @kimrutherford, fixed here and updated on revision 8824 of svn |
The cases like: FYECO:0000410(23.2ug/ml) and FYECO:0000005(32 C) Refs #1066
Thanks! I've finished the changes needed to load the conditions with temperatures and quantities into Chado. The new PHAF file loads perfectly now. I think this in done now. We now need to think about how to show this new information: |
FYPO_EXT:0000003
etc.feature_cvtermprop
)The text was updated successfully, but these errors were encountered: