add a 4th "Nightmare" difficulty #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only tested up to S04 ("Battle of Barnon") so far; still needs work
fix IF_DEBUG_MODE_IS_ACTUALLY_ON macro
This was referenced Apr 24, 2022
Closed
|
ok I think this is ready for testing/review now; taking out of draft mode |
also some additional Orannon changes, and clean up units/macros/abilities.cfg
This was referenced May 8, 2022
Hejnewar seemed to think it would be easy for him even on NIGHTMARE... it probably still will be even after this, but... oh well, I tried...
to set the diffs straight for this PR
|
Hey @knyghtmare I snuck in a reference to you in this difficulty... see if you can find it! |
|
Hey @Hejnewar any feedback on any of the rest of the scenarios beyond the first? |
nemaara
requested changes
May 17, 2022
minor prose fix Co-authored-by: nemaara <[email protected]>
cooljeanius
added a commit
to cooljeanius/A_New_Order
that referenced
this pull request
May 17, 2022
should be equivalent to cooljeanius/A_New_Order@6928bf6
|
OK I addressed most of those in 086c1d2; remaining tasks:
|
cooljeanius
added a commit
to cooljeanius/A_New_Order
that referenced
this pull request
May 17, 2022
should be equivalent to cooljeanius/A_New_Order@a3a19bf
I meant for this to be part of the previous commit
So, I finished these... |
nemaara
approved these changes
May 27, 2022
Merged
|
Oops I made the mistake of only testing this on NIGHTMARE, and forgetting to check that the other difficulties were still fine, thereby creating a bug that merging #62 will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only tested up to S04 ("Battle of Barnon") so far (by using debug mode); it still needs work (so I'm marking it as a draft), but you're more than welcome to test and stuff.Edit: I've done a full playthru (with debug mode) now; dunno how possible it is without debug mode, though...